Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Bug fix for broken symlink in verification test directory #704

Closed
wants to merge 2 commits into from

Conversation

mkavulich
Copy link
Collaborator

DESCRIPTION OF CHANGES:

In one of the final changes for #686 I renamed a file for one of the new consolidated WE2E tests, but failed to update the symbolic link from the "MET_ensemble_verification" test name. This commit fixes the link.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

TESTS CONDUCTED:

Ran ./run_WE2E_tests.py with the fixed symlink test, confirmed that the test was now able to be created and run correctly. Because this change does not affect any code, scripts, or automated tests (this test alias is not in any of the automated tests), I believe it does not require additional testing and can be merged as-is.

  • jet.intel

DEPENDENCIES:

None

DOCUMENTATION:

None

ISSUE:

None

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes

Fix broken symlink in verification test directory
… is now confirmed fixed on the command line.
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PR #686, grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_HRRR was renamed to grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16. This PR corrects the naming of the WE2E test for MET_ensemble_verification. Approving now.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Mar 29, 2023
@MichaelLueken
Copy link
Collaborator

@mkavulich Since this modification has been made to @christinaholtNOAA's PR #676, I will go ahead and resubmit the Jenkins tests and merge this PR's update through #676.

@mkavulich
Copy link
Collaborator Author

@MichaelLueken Thanks for noticing that, I forgot that I applied that fix there when settling merge conflicts. I will close this PR.

@mkavulich mkavulich closed this Mar 31, 2023
@mkavulich mkavulich deleted the mkavulich-patch-1 branch April 10, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants