Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Add more plotting WE2E tests #777

Merged

Conversation

EdwardSnyder-NOAA
Copy link
Collaborator

@EdwardSnyder-NOAA EdwardSnyder-NOAA commented May 5, 2023

DESCRIPTION OF CHANGES:

Adding more plotting tests as discussed in #741. This PR ensures that each coverage, comprehensive, and fundamental suites have at least one experiment that runs the plot_allvars task.

While testing this PR, I noticed that setting the plotting script to the regional domain for the RRFS_AK_13km domain results in a very unusual png output. This will be addressed in a later PR and will be tracked via issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

No documentation is needed.

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

Copy link
Collaborator

@natalie-perlin natalie-perlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four more tests with generating graphics, that's awesome! Maybe the corresponding tests without the graphics could eventually be retired from the test suites.

Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwardSnyder-NOAA I was able to successfully test the updated grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot test on Jet. It successfully passed and saw that the test produced the expected PNG plots. Approving PR.

@MichaelLueken MichaelLueken added enhancement New feature or request run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests labels May 12, 2023
@MichaelLueken
Copy link
Collaborator

@EdwardSnyder-NOAA There were a few failures in the Jenkins tests, but these failures were expected:

On Cheyenne GNU - the nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km test failed intermittently in the run_post tasks. This test has been failing since it was introduced in the WE2E coverage tests.

On Gaea - following the PrgEnv update last week, neither the SRW or weather model are able to build or run on the machine. Working with Natalie to correct this.

On Hera Intel - the grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta test failed in run_fcst (issue #731).

Since only expected tests failed and the updated plotting tests all passed and produced PNG files, so I will go ahead and merge this work now.

@MichaelLueken MichaelLueken merged commit b72ab14 into ufs-community:develop May 15, 2023
michelleharrold pushed a commit to michelleharrold/ufs-srweather-app that referenced this pull request Jun 7, 2023
Co-authored-by: Natalie Perlin <perlin.natalie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants