-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Add more plotting WE2E tests #777
[develop] Add more plotting WE2E tests #777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Four more tests with generating graphics, that's awesome! Maybe the corresponding tests without the graphics could eventually be retired from the test suites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EdwardSnyder-NOAA I was able to successfully test the updated grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot
test on Jet. It successfully passed and saw that the test produced the expected PNG plots. Approving PR.
@EdwardSnyder-NOAA There were a few failures in the Jenkins tests, but these failures were expected: On Cheyenne GNU - the On Gaea - following the PrgEnv update last week, neither the SRW or weather model are able to build or run on the machine. Working with Natalie to correct this. On Hera Intel - the Since only expected tests failed and the updated plotting tests all passed and produced PNG files, so I will go ahead and merge this work now. |
Co-authored-by: Natalie Perlin <perlin.natalie@gmail.com>
DESCRIPTION OF CHANGES:
Adding more plotting tests as discussed in #741. This PR ensures that each coverage, comprehensive, and fundamental suites have at least one experiment that runs the plot_allvars task.
While testing this PR, I noticed that setting the plotting script to the regional domain for the RRFS_AK_13km domain results in a very unusual png output. This will be addressed in a later PR and will be tracked via issue.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
No documentation is needed.
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):