-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop]: Updated exregional_get_obs scripts #833
[develop]: Updated exregional_get_obs scripts #833
Conversation
scripts/exregional_get_obs_ccpa.sh
Outdated
@@ -79,7 +79,7 @@ while [[ ${current_fcst} -le ${fcst_length} ]]; do | |||
vdd=`echo ${vdate} | cut -c7-8` # day (DD) of valid time | |||
vhh=`echo ${vdate} | cut -c9-10` # forecast hour (HH) | |||
|
|||
vhh_noZero=$(expr ${vhh} + 0) | |||
vhh_noZero=$( printf "%d" "${vhh#0}" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michelleharrold Is the #0
at the end something I suggested in our meeting? If so, sorry, it's not correct! Scrap that and change to $((10#${vhh}))
to force ${vhh}
to be interpreted as a decimal number. And please run a test!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsketefian -- what you originally suggested worked...until I tested on forecast hour 08 and 09, and then I got the dreaded octet error. So I had to modify it. I will go ahead and change to what you suggested and run it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michelleharrold Tests with different dates are passing without issue. I have also ran the fundamental WE2E tests on Hera Intel and they all passed. I will now approve this PR.
@michelleharrold The automated Jenkins tests passed on Cheyenne, Jet, and Hera. The WE2E coverage tests were manually run on Orion and all passed. Moving forward with merging this PR now.
|
DESCRIPTION OF CHANGES:
This PR addressed Issue #823. For more recent dates (June 2022 and beyond), the exregional_get_obs scripts fail because the tar files names on the NOAA HPSS were updated but not updated accordingly in the pull scripts. A simple fix of modifying the logic to account for mapping the valid date to the tar file name have been updated in
scripts/exregional_get_obs_ccpa.sh
,scripts/exregional_get_obs_mrms.sh
, andscripts/exregional_get_obs_ndas.sh
.As a note: To avoid having to continually update file name changes/location on the HPSS, we will be looking to leverage some of the capabilities being used for pulling DA observations and overhauling the verification observation pull scripts. @mkavulich will be looking into this soon.
Type of change
TESTS CONDUCTED:
The modifications were tested on Hera only. Several dates were tested (20220619, 20230515) for the FV3_HRRR suite over RRFS_CONUS_25km domain. 24-h simulations were run and included pulling obs from NOAA HPSS and running verification.
DEPENDENCIES:
None.
DOCUMENTATION:
N/A.
ISSUE:
Fixes issue mentioned in #823.
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):