Skip to content

Commit

Permalink
2D decomposition on write grid, bug fix in FV3GFS_IO.F90, and quad pr…
Browse files Browse the repository at this point in the history
…ecision in stochastic physics (#1028)

- The 2D decomposition is enabled on write grid component.
- FV3atm PR NOAA-EMC/fv3atm#468 from @MicroTed 
- stochastic physics PR NOAA-PSL/stochastic_physics#53 from Dom.

Co-authored-by: Ted Mansell <ted.mansell@noaa.gov>
Co-authored-by: Dom Heinzeller <heinzell@ucar.edu>
  • Loading branch information
3 people authored Feb 2, 2022
1 parent 4682914 commit 7b24880
Show file tree
Hide file tree
Showing 17 changed files with 5,581 additions and 5,536 deletions.
2 changes: 1 addition & 1 deletion FV3
2 changes: 1 addition & 1 deletion stochastic_physics
244 changes: 122 additions & 122 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

1,186 changes: 607 additions & 579 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

1,160 changes: 594 additions & 566 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

246 changes: 123 additions & 123 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

1,186 changes: 607 additions & 579 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

1,106 changes: 567 additions & 539 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

1,176 changes: 602 additions & 574 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

808 changes: 418 additions & 390 deletions tests/RegressionTests_wcoss_cray.log

Large diffs are not rendered by default.

3,924 changes: 1,862 additions & 2,062 deletions tests/RegressionTests_wcoss_dell_p3.log

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,7 @@ export RESTART_INTERVAL=0
export QUILTING=.true.
export WRITE_GROUP=1
export WRTTASK_PER_GROUP=6
export ITASKS=1
export OUTPUT_HISTORY=.true.
export WRITE_DOPOST=.false.
export NUM_FILES=2
Expand Down
1 change: 1 addition & 0 deletions tests/parm/model_configure.IN
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ output_1st_tstep_rst: .false.
quilting: @[QUILTING]
write_groups: @[WRITE_GROUP]
write_tasks_per_group: @[WRTTASK_PER_GROUP]
itasks: @[ITASKS]
output_history: @[OUTPUT_HISTORY]
write_dopost: @[WRITE_DOPOST]
num_files: @[NUM_FILES]
Expand Down
1 change: 1 addition & 0 deletions tests/parm/model_configure_regional.IN
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ output_1st_tstep_rst: .false.
quilting: @[QUILTING]
write_groups: 1
write_tasks_per_group: 8
itasks: @[ITASKS]
write_dopost: @[WRITE_DOPOST]
num_files: 2
filename_base: 'dyn' 'phy'
Expand Down
2 changes: 2 additions & 0 deletions tests/rt.conf
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ RUN | cpld_debug_p8
COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16,FV3_GFS_v15_thompson_mynn,FV3_GFS_v15_thompson_mynn_RRTMGP,FV3_GFS_v16_p7_rrtmgp,FV3_GFS_v16_p8 -D32BIT=ON | | fv3 |
RUN | control | | fv3 |
RUN | control_decomp | | |
RUN | control_2dwrtdecomp | | |
RUN | control_2threads | - wcoss_cray | |
RUN | control_restart | | | control
RUN | control_fhzero | - wcoss2 | |
Expand All @@ -58,6 +59,7 @@ RUN | control_p7_rrtmgp

RUN | regional_control | | fv3 |
RUN | regional_restart | | | regional_control
RUN | regional_control_2dwrtdecomp | | |
RUN | regional_noquilt | | fv3 |
RUN | regional_2threads | - wcoss_cray jet.intel | |
RUN | regional_hafs | | fv3 |
Expand Down
34 changes: 34 additions & 0 deletions tests/tests/control_2dwrtdecomp
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
###############################################################################
#
# Global 2D write domain decomposition test
#
###############################################################################

export TEST_DESCR="Compare global 2D write decomp results with control test"

export CNTL_DIR=control

export LIST_FILES="sfcf000.nc \
sfcf024.nc \
atmf000.nc \
atmf024.nc"
export_fv3
export NPZ=127
export NPZP=128
export DT_ATMOS=720
export SYEAR=2021
export SMONTH=03
export SDAY=22
export SHOUR=06
export RESTART_INTERVAL=0
export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.false.
export IAER=5111

export IOVR=3
export ITASKS=2

export FV3_RUN=control_run.IN
export CCPP_SUITE=FV3_GFS_v16
export INPUT_NML=control.nml.IN
38 changes: 38 additions & 0 deletions tests/tests/regional_control_2dwrtdecomp
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
###############################################################################
#
# FV3 regional 2D write decomposition domain test
#
###############################################################################

export TEST_DESCR="Compare FV3 regional 2D write decomposition domain with control test"

export CNTL_DIR=fv3_regional_control

export LIST_FILES="dynf000.nc \
dynf024.nc \
phyf000.nc \
phyf024.nc"

export_fv3

export FV3_RUN=regional_run.IN

export OZ_PHYS_OLD=.false.
export OZ_PHYS_NEW=.true.
export H2O_PHYS=.true.
export HYBEDMF=.false.
export RESTART_INTERVAL="12 -1"
export WRITE_DOPOST=.false.
export POSTAPP='lam'

export CCPP_SUITE=FV3_GFS_v15_thompson_mynn
export INPUT_NML=regional.nml.IN
export MODEL_CONFIGURE=model_configure_regional.IN
export DIAG_TABLE=diag_table_lam
export FIELD_TABLE=field_table_regional

export TASKS=68
export INPES=10
export JNPES=6
export ITASKS=2
export OUTPUT_FH="12 -1"

0 comments on commit 7b24880

Please sign in to comment.