Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rt thread test #559

Closed
MinsukJi-NOAA opened this issue May 5, 2021 · 1 comment
Closed

rt thread test #559

MinsukJi-NOAA opened this issue May 5, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@MinsukJi-NOAA
Copy link
Contributor

Description

A couple of issues regarding the current 2 thread test in rt.sh:

  • Not consistent between fv3 and cpld
    • fv3 reduces TPN by 2, so that each thread runs on its own core
    • cpld does not reduce TPN by 2, so that 2 threads run on the same core
  • Layout change; e.g. from 8x4 to 8x2
    • Should we keep the layout the same so that only threading, and not decomposition, is tested? This has recently been highlighted from regional 2 thread test Regional threading test failture  #546
    • Should we run each thread on its own core? This can be costly, especially for cpld model
    • If we run 2 threads on a same core, is it still a good thread testing?

Related to

#543
@MinsukJi-NOAA MinsukJi-NOAA added the enhancement New feature or request label May 5, 2021
@MinsukJi-NOAA
Copy link
Contributor Author

This issue seems to have been addressed by #544

epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@JeffBeck-NOAA
Revert "Modifications to allow workflow to run to completion with GNU…
c7c48a3 
… build on Hera (#526)" (#559)

This reverts commit 19a872b.
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@mkavulich @zmoon
[develop] Fix issue 541: correct error message when config.yaml has i…
fc72f4e 
…nvalid entries (#559)

This is actually two fixes/enhancements, one required by the other:

1) Fix error message that appears when user specifies an invalid key in their config.yaml file. The current version references undefined variables and appears to be a copy/paste error from some other exception.

2) In order to achieve the above neatly, I had to change the behavior of the python_utils function check_structure_dict(). Rather than simply printing the invalid key/value pair, it now returns a dictionary of invalid key/value pairs (that is empty if all keys are valid). I also fixed a minor bug here: even though this function claimed to detect all invalid entries, it actually only printed the first before returning. Now all invalid entries are returned.

---------

Co-authored-by: Zachary Moon <zmoon92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MinsukJi-NOAA