Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D diagnostics for Thompson scheme #659

Closed
ericaligo-NOAA opened this issue Jun 23, 2021 · 4 comments
Closed

Add 3D diagnostics for Thompson scheme #659

ericaligo-NOAA opened this issue Jun 23, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@ericaligo-NOAA
Copy link
Collaborator

Description

Provide a clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Solution

Add a clear and concise description of what you want to happen.

Alternatives

If applicable, add a description of any alternative solutions or features you've considered.

Related to

Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:

  • required to support noaa-emc/nems/issues/<issue_number>
  • needed by noaa-emc/fv3atm/pull/<pr_number>
@SamuelTrahanNOAA
Copy link
Collaborator

@ericaligo-NOAA Is this issue resolved by #660, which added 3d diagnostic tendencies for all tracers and schemes? It added diagnostic tendencies for the microphysics scheme in its entirety; not any processes within the scheme.

@ericaligo-NOAA
Copy link
Collaborator Author

ericaligo-NOAA commented Jul 21, 2021 via email

@SamuelTrahanNOAA
Copy link
Collaborator

That would be "no" then. PR #660 did not add any diagnostics inside the Thompson scheme.

@climbfuji
Copy link
Collaborator

climbfuji commented Jul 21, 2021

That would be "no" then. PR #660 did not add any diagnostics inside the Thompson scheme.

EDIT: Misunderstanding. The special Thompson diagnostics were added in a previous PR, this issue is resolved.

epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
…sk (from GridStat and EnsembleStat tasks) (#659)

Split calls to METplus's PcpCombine tool out of the tasks that run (1) deterministic verification (vx) using the GridStat tool and (2) ensemble vx using the EnsembleStat tool into separate tasks.

Other changes not directly related to new PcpCombine tasks:
 * In all METplus conf files for deterministic vx tasks (GridStat_APCP[[01|03|06|24]h|REFC|RETOP].conf and PointStat_[SFC|UPA].conf), append the name of the ensemble member (if operating on an ensemble forecast) to the MODEL variable.
* In the ex-scripts for EnsembleStat (exregional_run_met_ensemblestat_[grid|point].sh), use the experiment variable VX_FCST_INPUT_BASEDIR instead of EXPTDIR to set the input base directory.
* For clarity, rename the experiment variables GET_OBS and TN_VX to GET_OBS_LOCAL_MODULE_FN and VX_LOCAL_MODULE_FN, respectively.
* Move the LOG_DIR variable from some of the METplus tool-specific configuration files to the shared (among all METplus tools) file common.conf since it is defined in the same way in all the tool-specific files.
* Add the new experiment variables RUN_TASKS_METVX_DET and/or RUN_TASKS_METVX_ENS to the WE2E vx tests MET_verification, MET_verification_only_vx, and MET_ensemble_verification since these are now needed in order to run verification tasks.
* Modify process_args.sh so that it can handle a value in a key-value pair (key=value) that contains an equal sign.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants