Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible history file output time and consistent control variables #674

Closed
junwang-noaa opened this issue Jun 29, 2021 · 2 comments · Fixed by #691
Closed

flexible history file output time and consistent control variables #674

junwang-noaa opened this issue Jun 29, 2021 · 2 comments · Fixed by #691
Labels
enhancement New feature or request

Comments

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Jun 29, 2021

Description

Currently the ufs weather model fv3atm component can not output history files at flexible forecast time. Also there are two sets of variables controlling when to output the history files. One in the fv3 forecast component, namelist variables fdiag, fhout,fhmax, fhouthf, fhmaxhf are used, the other set is used by the write grid component with variables nfhout, nfhmax, nfhout_hf, nfhmax_hf, nsout in model_configure. This causes some issues when inconsistent setting are used at run time.

Solution

In this issue, the control variables are cleaned up. Only one set of control variables will be used in the fv3 cap to control when to update data buffer on forecast side and when to pick up those data and write out to history files on write grid component side. Also a configuration variable output_fh is introduced to output history files at forecast times users choose, because of that the ESMF alarm is removed as it can't support irregular alarm frequency. So code updates include:

  1. fdiag, fhout,fhmax, fhouthf, and fhmaxhf are removed from fv3 namelist atmos_model_nml. With the code updates, those variables should be deleted from namelist.
  2. in model_configure, there are two ways to control output forecast time
  • Use nfhout, nfhmax, nfhout_hf, nfhmax_hf, nsout, the meanings of those variables do not change.
  • Use output_fh to control output time:
    a) An array of output_fh means to output history files at those forecast time, e.g.:
    "output_fh: 0 1 2 3 12 24 48"
    If the first elelment is zero, it means the first time step output.
    b) If there are two elements in output_fh and the second one has value -1, it means the first element is output frequency. e.g.
    " output_fh: 6 -1"
    fv3atm will output the history file every 6 hours.

Related to

  • It will resolve issue #339
    FV3 and ufs-weather-model PRs will be created.
@junwang-noaa junwang-noaa added the enhancement New feature or request label Jun 29, 2021
@SMoorthi-emc
Copy link
Contributor

SMoorthi-emc commented Jun 29, 2021 via email

@junwang-noaa
Copy link
Collaborator Author

junwang-noaa commented Jun 29, 2021 via email

epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
…w generation layer (#674)

* Add python utility functions mirroring bash utils.

* Add str_to_list utility, export varibales to environment
Import env variables as numeric values to ease calculations.
Address some of Christina's points.

* Use dedent for multiline string formatting.

* Bug fix with export_vars.

* Bug fix with set_env_var

* Add !join  tag to yaml.

* Bug fix with date conversion.

* Beautify print_input_args.

* Import stuff to __init__.py

* Write dates in short form when HHMM = 0

* Clarify type conversions.

* Add option to parse old style shell user config

* Bug fix with handling same line comments

* Minor bug fixes

* Source complex config shell scripts instead of trying to parse.

* Modify config shell script loading routine.

* Update comments.

* Addressing some of Christina's comments.

* Removing set_bash/file_param.

* Minor changes in unittests.

* Remove unused config script parser.

* Avoid passing os.environ as default.

* Fix name of macos utils.

* Add typical regional workflow resoultions to the test.

* Add a copy of Externals.cfg to test.

* More changes to address @gsketefian's suggestions.

Co-authored-by: Daniel Shawul <dshawul@yahoo.com>
epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
#674)

Updated the data file paths to point from SRW account locations to EPIC role account locations, so that EPIC can have better control and management of the SRW App data files.

Also added the FIXgsi var.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants