Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupling merra2 aerosol climatology and GOCART forecasted aerosols with the Thompson microphysics scheme #1438

Merged

Conversation

ChunxiZhang-NOAA
Copy link
Contributor

@ChunxiZhang-NOAA ChunxiZhang-NOAA commented Sep 23, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

This PR is associated with the ccpp-physics PR#2 to add the coupling capability between merra2 aerosol climatology or GOCART forecasted aerosols with the Thompson microphysics scheme. Two new RTs were added into rt.conf, e.g., merra2_thompson and atmaero_control_p8_rad_micro. Otherwise, it will not change the BL.

Issue(s) addressed

  • fixes #<4>

Testing

A full set of RTs is done on hera.intel. ORTs for these two new RT passed on hera.intel, please see attached file for one of the tests.
OpnReqTests_atmaero_control_p8_rad_micro_hera.intel.log.txt

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

  • waiting on ufs-community/ccpp-physics/pull/<2>
  • waiting on noaa-emc/fv3atm/pull/<588>

on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: BL
[BL] Repo location: /work/noaa/nems/emc.nemspara/autort/pr/1065652889/20220929181510/ufs-weather-model
[BL] Error: Test compile_001 failed in run_compile failed
[BL] Error: Test compile_002 failed in run_compile failed
[BL] Error: Test compile_003 failed in run_compile failed
[BL] Error: Test compile_004 failed in run_compile failed
[BL] Error: Test compile_005 failed in run_compile failed
[BL] Error: Test compile_006 failed in run_compile failed
[BL] Error: Test compile_007 failed in run_compile failed
[BL] Error: Test compile_008 failed in run_compile failed
[BL] Error: Test compile_009 failed in run_compile failed
[BL] Error: Test compile_010 failed in run_compile failed
[BL] Error: Test compile_011 failed in run_compile failed
[BL] Error: Test compile_012 failed in run_compile failed
[BL] Error: Test compile_013 failed in run_compile failed
[BL] Error: Test compile_014 failed in run_compile failed
[BL] Error: Test compile_015 failed in run_compile failed
[BL] Error: Test compile_016 failed in run_compile failed
[BL] Error: Test compile_017 failed in run_compile failed
[BL] Error: Test compile_018 failed in run_compile failed
[BL] Error: Test compile_021 failed in run_compile failed
[BL] Error: Test compile_022 failed in run_compile failed
[BL] Error: Test compile_023 failed in run_compile failed
Please make changes and add the following label back: orion-intel-BL

@jkbk2004
Copy link
Collaborator

On orion, it seems to force to use "module load git/2.28.0" on autoRT. Manual runs are working ok. On jet, ecflow issue continues. EPIC CM will issue help desk ticket. jet/rocoto work well but cpld_esmfthreads_p8 (TASKS issue in rocoto run, manual/single run works). #1431 might be helpful for the rocoto tasks cal.

@jkbk2004
Copy link
Collaborator

All the tests are done. We can start merging in the PR. Dependency PRs first. @ChunxiZhang-NOAA go ahead to merge in ccpp pr.

@ChunxiZhang-NOAA
Copy link
Contributor Author

All the tests are done. We can start merging in the PR. Dependency PRs first. @ChunxiZhang-NOAA go ahead to merge in ccpp pr.

@jkbk2004 I've merged the ccpp PR in. I also updated the fv3atm pointer. fv3atm is ready to merge.

@jkbk2004
Copy link
Collaborator

@ChunxiZhang-NOAA fv3atm pr merged. We can ask final approval and merge this pr after reverting branch in gitmodules and update fv3atm submodule pointer.

@ChunxiZhang-NOAA
Copy link
Contributor Author

@jkbk2004 gitmodules is reverted and fv3atm submodule pointer is modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants