Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in pt-source change for AQM #1457

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

See issue: NOAA-EMC/AQM/issues/13

Issue(s) addressed

Addresses: /NOAA-EMC/AQM/issues/13

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

Depends on: NOAA-EMC/AQM/pull/18

@BrianCurtis-NOAA
Copy link
Collaborator Author

Baseline changes for regional_atmaq anticipated:

baseline dir = /lfs/h2/emc/nems/noscrub/emc.nems/RT/NEMSfv3gfs/develop-20221007/INTEL/regional_atmaq
working dir  = /lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_181191/regional_atmaq
Checking test 001 regional_atmaq results ....
 Comparing sfcf000.nc .........OK
 Comparing sfcf003.nc .........OK
 Comparing sfcf006.nc .........OK
 Comparing atmf000.nc ............ALT CHECK......NOT OK
 Comparing atmf003.nc ............ALT CHECK......NOT OK
 Comparing atmf006.nc ............ALT CHECK......NOT OK
 Comparing RESTART/coupler.res .........OK
 Comparing RESTART/fv_core.res.nc .........OK
 Comparing RESTART/fv_core.res.tile1.nc .........OK
 Comparing RESTART/fv_srf_wnd.res.tile1.nc .........OK
 Comparing RESTART/fv_tracer.res.tile1.nc ............ALT CHECK......NOT OK
 Comparing RESTART/phy_data.nc .........OK
 Comparing RESTART/sfc_data.nc .........OK
Test 001 regional_atmaq FAIL

@BrianCurtis-NOAA BrianCurtis-NOAA added the Baseline Updates Current baselines will be updated. label Oct 17, 2022
@BrianCurtis-NOAA
Copy link
Collaborator Author

Does reproduce with new baselines:

baseline dir = /lfs/h2/emc/ptmp/brian.curtis/FV3_RT/REGRESSION_TEST_INTEL/regional_atmaq
working dir  = /lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_114814/regional_atmaq
Checking test 001 regional_atmaq results ....
 Comparing sfcf000.nc .........OK
 Comparing sfcf003.nc .........OK
 Comparing sfcf006.nc .........OK
 Comparing atmf000.nc .........OK
 Comparing atmf003.nc .........OK
 Comparing atmf006.nc .........OK
 Comparing RESTART/coupler.res .........OK
 Comparing RESTART/fv_core.res.nc .........OK
 Comparing RESTART/fv_core.res.tile1.nc .........OK
 Comparing RESTART/fv_srf_wnd.res.tile1.nc .........OK
 Comparing RESTART/fv_tracer.res.tile1.nc .........OK
 Comparing RESTART/phy_data.nc .........OK
 Comparing RESTART/sfc_data.nc .........OK
Test 001 regional_atmaq PASS

@BrianCurtis-NOAA
Copy link
Collaborator Author

Moving to draft to match AQM PR.

@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as draft October 21, 2022 23:58
@BrianCurtis-NOAA
Copy link
Collaborator Author

Fixed in #1560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant