-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cmeps with fix for mediator history files; use esmf-managed threading for cpld_bmark control and restart (was #1483); Software module updates in hpc-stack for Hera (intel, gnu) (was #1468) #1486
Merged
jkbk2004
merged 30 commits into
ufs-community:develop
from
DeniseWorthen:feature/updcmeps
Nov 16, 2022
Merged
update cmeps with fix for mediator history files; use esmf-managed threading for cpld_bmark control and restart (was #1483); Software module updates in hpc-stack for Hera (intel, gnu) (was #1468) #1486
jkbk2004
merged 30 commits into
ufs-community:develop
from
DeniseWorthen:feature/updcmeps
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* include land component changes from ESCOMP/master for UFS
* bmark cpld tests use esmf-managed threading by default * remove version w/o esmf-managed threading
* feature is now in cpld_bmark by default
@DeniseWorthen can we combine #1483 to this pr? #1468 is ready to be combined to this pr as well. |
Regarding, ccpp pr 17, I don't think we need to combine to this pr. It is only ccpp git workflow/action yaml file change. So it will be much easier to be directly combined to other ccpp PRs. |
6 tasks
DeniseWorthen
changed the title
update cmeps with fix for mediator history files
update cmeps with fix for mediator history files; use esmf-managed threading for cpld_bmark control and restart (was #1483)
Nov 15, 2022
* bmark_p8 test is not run on cheyenne
16 tasks
DeniseWorthen
changed the title
update cmeps with fix for mediator history files; use esmf-managed threading for cpld_bmark control and restart (was #1483)
update cmeps with fix for mediator history files; use esmf-managed threading for cpld_bmark control and restart (was #1483); Software module updates in hpc-stack for Hera (intel, gnu) #1468
Nov 16, 2022
zach1221
added
gaea-intel-RT
jenkins-ci
Jenkins CI: ORT build/test on docker container
labels
Nov 16, 2022
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
DeniseWorthen
changed the title
update cmeps with fix for mediator history files; use esmf-managed threading for cpld_bmark control and restart (was #1483); Software module updates in hpc-stack for Hera (intel, gnu) #1468
update cmeps with fix for mediator history files; use esmf-managed threading for cpld_bmark control and restart (was #1483); Software module updates in hpc-stack for Hera (intel, gnu) (was #1468)
Nov 16, 2022
jkbk2004
requested review from
BrianCurtis-NOAA,
jkbk2004 and
DusanJovic-NOAA
November 16, 2022 13:03
DusanJovic-NOAA
approved these changes
Nov 16, 2022
BrianCurtis-NOAA
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Fixes mediatory history files when fields contain ungridded dimensions.
Issue(s) addressed
Testing
All hera.intel and hera.gnu baselines were b4b at a1622b9
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
waiting on NOAA-EMC/CMEPS#75