Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
CMakeLists.txt
requires static builds ofparallelio
(see these lines). A relaxation of this requirement (i.e.: to allow shared or static versions ofparallelio
) could be facilitated by updatingCMakeModules
to its develop branch, whereFindPIO.cmake
can automatically accommodate both static or shared builds.Apart from updating
CMakeModules
to develop, theSTATIC
requirement would need to be removed fromCMakeLists.txt
.This change is in anticipation of transition from hpc-stack to spack-stack, where
parallelio
is currently being built as a shared library (see NOAA-EMC/spack-stack PR #454, issue #478).RT
cpld_contrl_p8
passed on Orion (Intel) and Hera (Intel & GNU) (logs in comments). I will report further RT results as they complete.Anticipated changes to regression tests:
Subcomponents involved:
Commit Queue Checklist:
Linked PR's and Issues:
Addresses #1512
Testing Day Checklist:
Testing Log (for CM's):