Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable usage of shared pio #1640

Closed
wants to merge 2 commits into from

Conversation

ulmononian
Copy link
Collaborator

@ulmononian ulmononian commented Mar 3, 2023

Description

Currently, CMakeLists.txt requires static builds of parallelio (see these lines). A relaxation of this requirement (i.e.: to allow shared or static versions of parallelio) could be facilitated by updating CMakeModules to its develop branch, where FindPIO.cmake can automatically accommodate both static or shared builds.

Apart from updating CMakeModules to develop, the STATIC requirement would need to be removed from CMakeLists.txt.

This change is in anticipation of transition from hpc-stack to spack-stack, where parallelio is currently being built as a shared library (see NOAA-EMC/spack-stack PR #454, issue #478).

RT cpld_contrl_p8 passed on Orion (Intel) and Hera (Intel & GNU) (logs in comments). I will report further RT results as they complete.

Anticipated changes to regression tests:

  • [ x] No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • [x ] CMakeModules

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Addresses #1512

Testing Day Checklist:

  • [x ] This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • [x ] Hera
      • [ x] Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • [ x] Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@ulmononian
Copy link
Collaborator Author

ulmononian commented Mar 3, 2023

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 6, 2023

@ulmononian we are considering to combine in #1617. I will keep you posted to finalize the review process of this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants