Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CDEPS component in ufs-weather-model #1741

Closed
wants to merge 5 commits into from
Closed

Update CDEPS component in ufs-weather-model #1741

wants to merge 5 commits into from

Conversation

binli2337
Copy link
Contributor

@binli2337 binli2337 commented May 8, 2023 •
edited
Loading

Description

The CDEPS repository has been updated. The CDEPS component in the ufs-weather-model needs to be updated.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

NOAA-EMC/CDEPS#55
Fixes #1740

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@zach1221 zach1221 mentioned this pull request May 22, 2023
Merged
37 tasks
@zach1221
Copy link
Collaborator

Hi, @binli2337 . We're going to create a PR soon to your branch to combine #1699 with this PR. In anticipation of that, could you sync up your branch with this PR so it's up to date, please?

@jkbk2004
Copy link
Collaborator

@binli2337 can you sync up branch? If we can combine in #1669, we can start working on this pr.

@zach1221
Copy link
Collaborator

Hi, @binli2337 your changes have been combined into #1699 , so we can work from that PR to merge both yours and Sadegh changes. Please let me know if you have any issues with this.

zach1221 pushed a commit that referenced this pull request May 25, 2023
@SadeghTabas-NOAA @binli2337
Updating nemelist templates and configuration files to have consisten…
daa456c 
…t format as the global workflow; Update CDEPS (was #1741) (#1699)

* Update cpld_control.nml.IN

* Update model_configure.IN

* Update nems.configure.cpld_noaero.IN

* Update field_table_thompson_noaero_tke

* Rename diag_table_gfsv17_template to diag_table_cpld_template

* Update CDEPS-interface/cdeps_files.cmake

Co-authored-by: Bin.Li <bin.li@noaa.gov>
Co-authored-by: SadeghTabas-NOAA <SadeghTabas-NOAA@users.noreply.github.com>
@zach1221
Copy link
Collaborator

Changes from this PR were combined into #1699 . PR #1699 has just been merged into ufs-community:develop, so this PR can now be closed.

@zach1221 zach1221 closed this May 25, 2023
@binli2337 binli2337 deleted the feature/update_cdeps branch June 1, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CDEPS component in ufs-weather-model
3 participants
@binli2337 @zach1221 @jkbk2004