Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hrrr quilting restart tests #1853

Closed

Conversation

DusanJovic-NOAA
Copy link
Collaborator

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Small change in fv3atm quilting restart write routine to make all axis in the physics restart files use double values (instead of float even when physics is compiled in 32 bit) to make the files identical to FMS restart files. With this change we can have all tests that run quilting use the same baselines as corresponding control tests.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Closes #1832

Subcomponent Pull Requests

NOAA-EMC/fv3atm/pull/683

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DusanJovic-NOAA
Copy link
Collaborator Author

RegressionTests_hera.log

zach1221 pushed a commit that referenced this pull request Aug 31, 2023
…bining PRs #1853 & 1834) (#1467)

* Update fms to 2022.04. Update acorn modulefiles

* Remove fms_io_nml and mpp_io_nml namelists from input.nml templates

* Update FMS to 2023.01

* Use netcdf4 fms2_io option

* replace tabs with spaces

* Update rt.sh to allow creating new baselines only for a subset of tests

* Update rt.sh to run compile tasks only if needed during baseline creation (-b option)

* Revert MAX_BUILDS back to 10

* Fix hrrr qutlting restart tests.
@zach1221
Copy link
Collaborator

Changes combined into #1467 . Closing

@zach1221 zach1221 closed this Aug 31, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the fix_qr_tests branch August 31, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several issues with how some of the hrrr 'quilt restart' tests are configured
3 participants