Add 3-moment option for NSSL cloud microphysics

[MicroTed]

PR Author Checklist:

• I have linked PR's from all sub-components involved in section below.
• I am confirming reviews are completed in ALL sub-component PR's.
• I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • LOG: RegressionTests_hera.log.nssl3m.txt
• I have added the list of all failed regression tests to "Anticipated changes" section.
• I have filled out all sections of the template.

Description

Adds support for NSSL microphysics option of 3-moment rain, graupel, and hail (or just rain and graupel if the hail species is deactivated). This predicts the reflectivity moment (6th moment in diameter), which in turn predicts the shape parameter of the gamma function particle size distribution.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

N/A

Subcomponent Pull Requests

PR for CCPP: ufs-community/ccpp-physics#110
PR for FV3 with added variables needed by CCPP: NOAA-EMC/fv3atm#702

Blocking Dependencies

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Anticipated Changes

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

Tests affected by changes in this PR:

Yes, it will change regional_wofs, rrfs_v1nssl, and rrfs_v1nssl_nohailnoccn because of some changes to the NSSL microphysics scheme that is used with the tests. Failed tests (comparisons): regional_wofs, rrfs_v1nssl, rrfs_v1nssl_nohailnoccn

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Code Managers Log

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
  • N/A

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[MicroTed]

The addition of -mcmodel=medium to Intel.cmake was needed on jet to avoid a link error. I think this is because jet compiles for multiple targets, which increases the code size enough to not fit in the 'small' mcmodel. (No problem on hera)

[grantfirl]

@MicroTed Is this ready to be out of draft?

[MicroTed]

@grantfirl I suppose so, and the FV3 one, too.

[zach1221]

Hi, @MicroTed . I think we're ready to begin testing of this PR next. Can you please sync up your branch to resolve conflicts?

[jkbk2004]

@MicroTed can you sync up at the fv3atm level? Ihttps://github.com/NOAA-EMC/fv3atm/pull/702

[MicroTed]

@jkbk2004 I think everything should be up to date now.

[zach1221]

@jkbk2004 @BrianCurtis-NOAA beginning testing of this PR.

[FernandoAndrade-NOAA]

@BrianCurtis-NOAA FYI, the cpld_bmark_p8_intel BL creation needed an increase in time limit for Gaea within default_vars.sh. A standalone test creation run for that case showed in the timestamp that it took around 36-37 minutes, a bit over the default of 30 I believe.

[DeniseWorthen]

The last commit for the cpld_bmark_p8 test on gaea showed

   0: The total amount of wall time                        = 606.710669

[FernandoAndrade-NOAA]

Just to be clear, this timeout was during the BL creation run for rt.sh. After the time limit increase, there was no issue and the current successful Gaea log for this PR shows around the same runtime at 604.509965.
The previously failed run on Gaea is available at
/lustre/f2/scratch/Fernando.Andrade-maldonado/FV3_RT/rt_21322/cpld_bmark_p8_intel/

[BrianCurtis-NOAA]

I don't understand. Were all baselines generated on RDHPCS or just the new ones listed in this PR ?

[jkbk2004]

On hera, I confirm that only nssl and wof cases change results.

[zach1221]

Right, just regional_wofs, rrfs_v1nssl, and rrfs_v1nssl_nohailnoccn baselines changed.

[BrianCurtis-NOAA]

On hera, I confirm that only nssl and wof cases change results.

I copied over the 20231024 baselines to 20231102 and did baselines for the nssl/wofs tests and a large percentage of my tests failed in comparison.

I wanted to confirm in the process of creating baselines, that you copied over the old baselines to the new baselines and added the changed baselines.

[BrianCurtis-NOAA]

I will re-do my git clone and try once more.

[zach1221]

@BrianCurtis-NOAA yes, I copied existing from 20231024 over to 20231102, then created new ones for those three cases mentioned previously, added them to 20231102. Then finally ran the matching against 20231102.

[BrianCurtis-NOAA]

@BrianCurtis-NOAA yes, I copied existing from 20231024 over to 20231102, then created new ones for those three cases mentioned previously, added them to 20231102. Then finally ran the matching against 20231102.

Thanks Zach, then it was probably me. Apologies for the delay.

[jkbk2004]

@BrianCurtis-NOAA acorn test underway?

[zach1221]

Regression testing is complete. I'll follow up on the ccpp-physics PR to begin the merging process.

[zach1221]

@MicroTed please revert .gitmodule url changes and update the submodule hash for fv3atm.
hash:0dbc9ed837c3b179f545696ef93ac950e1f816ea

[MicroTed]

@zach1221 Thanks! They should be updated now