Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporate csawMG update and pass both intel and GNU RT tests #2130

Closed

Conversation

AnningCheng-NOAA
Copy link
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Feb 12, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
  • Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

CSAW missed a major update and cannot pass RTs for GNU compiler. Both are fixed in this PR

Commit Message

https://github.com//issues/552

Priority

  • Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
  • High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
  • Normal

Blocking Dependencies

NOAA-EMC/fv3atm#782
ufs-community/ccpp-physics#171

Git Issues Fixed By This PR

Changes

Changes mainly made in csaw

Subcomponent (with links)

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
  • all csawmg related tests needs new baseline, So eight related tests failed
FAILED REGRESSION TESTS ``` 079 control_csawmg_intel failed in check_result control_csawmg_intel 079 failed in run_test 080 control_csawmgt_intel failed in check_result control_csawmgt_intel 080 failed in run_test 082 control_csawmg_gnu failed in check_result control_csawmg_gnu 082 failed in run_test 083 control_csawmgt_gnu failed in check_result control_csawmgt_gnu 083 failed in run_test 091 control_csawmg_debug_intel failed in check_result control_csawmg_debug_intel 091 failed in run_test 092 control_csawmgt_debug_intel failed in check_result control_csawmgt_debug_intel 092 failed in run_test 114 control_csawmg_debug_gnu failed in check_result control_csawmg_debug_gnu 114 failed in run_test 115 control_csawmgt_debug_gnu failed in check_result control_csawmgt_debug_gnu 115 failed in run_test ```

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@AnningCheng-NOAA
Copy link
Contributor Author

RegressionTests_hera.log

@grantfirl
Copy link
Collaborator

@jkbk2004 This can be closed in favor of #2180. This is just for merging/testing/updating convenience.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 8, 2024

closed to follow up with #2180

@jkbk2004 jkbk2004 closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants