Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for ccpp-physics routine sfcsub.F #2253

Closed

Conversation

GeorgeGayno-NOAA
Copy link
Contributor

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Apr 26, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on Hera.
  • Commit 'test_changes.list' from previous step

Description:

A bug fix was made to ccpp-physics routine sfcsub.F. This PR updates the version
of ccpp-physics used by ufs-weather-model.

Commit Message:

  • FV3 -
    • ccpp-physics - In sfcsub.F, fix the setting of the model land mask used to interpolate GLDAS data.

Priority:

  • Normal

Git Tracking

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@GeorgeGayno-NOAA
Copy link
Contributor Author

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 7, 2024

@GeorgeGayno-NOAA Can you sync up the branches? We will try to see if we can combine along with #2215 and #2254.

@grantfirl
Copy link
Collaborator

@GeorgeGayno-NOAA Can you sync up the branches? We will try to see if we can combine along with #2215 and #2254.

@jkbk2004 I've already combined this into #2264. I'll get it updated, although there was a little discussion left on one of the combined ccpp-physics PRs that is finishing up.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 7, 2024

@GeorgeGayno-NOAA Can you sync up the branches? We will try to see if we can combine along with #2215 and #2254.

@jkbk2004 I've already combined this into #2264. I'll get it updated, although there was a little discussion left on one of the combined ccpp-physics PRs that is finishing up.

@grantfirl thanks for the note! it helps. We will separately go with #2215 and #2254.

@grantfirl
Copy link
Collaborator

@jkbk2004 This can be closed in favor of #2264

@jkbk2004 jkbk2004 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants