-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update WAM RT compatible with v17 #2283
Conversation
@DusanJovic-NOAA do we have "rules" for the INPUTDATA_ROOT dir for placing things? I would think maybe the WAM items could go into a new directory named |
Where are 'wam' input data currently stored? Isn't 'wam' just another configuration of global, uncoupled fv3 configuration. What makes 'wam' a wam compared to control_p8 for example? How are input/IC data used in 'wam' different than what's currently used in other fv3 configurations? |
@BrianCurtis-NOAA Do we know this new test passes all the oRTs? |
This doesn't seem to be a new test, but it won't hurt to have @zach1221 run the ORT on it once all requested changes are taken care of. |
Thanks @zach1221. It appears this test is different enough (v16->v17) that it warrants treatment as "new". |
Hi, @WChen-NOAA can you please sync up this PR's branch so I can begin ORTs? |
@zach1221 This is the first time I am working on the UFS-WM PRs. Confused by "sync up this PR's branch so I can begin ORTs". Is this to update my branch with the UFS-WM develop branch? |
You are correct. |
the ICs needs to use the cold ICs in (HERA) /scratch1/NCEPDEV/global/Wen.Chen/models/PRs/FV3_input_data_L149 |
Are there overwrites of files in FV3_input_data_L149 or all new files? This would help us determine if we need to create a new input-data directory for these changes. |
@BrianCurtis-NOAA Please overwrite the files in FV3_input_data_L149. |
could I start the full suite RTs on HERA? or waiting for a while? |
I think we should name it FV3_input_data_L149_wam on the input-data directory so that we don't need to create a new input-data directory for this. Could you make changes in your code to accommodate this? Only exception would be knowing that nobody else uses L149 and nobody in the WAM group would need the older inputs in the future. I'd rather not overwrite, though. |
You can run these at any time your code is ready. We expect that no changes (minus keeping up to date with develop branch) would be needed afterwards. |
@WChen-NOAA I assume directory INPUT_C should be created as new in FV3_input_data_L149, as it doesn't currently exist, or should the files in /scratch1/NCEPDEV/stmp2/Wen.Chen/FV3WAM/fv3wam_data_src/INPUT_C be copied to /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20240501/FV3_input_data_L149/INPUT ? |
@zach1221 @FernandoAndrade-NOAA updated derecho modulefiles for SSv1.6 |
FYI, Jet does not seem like it's ready to run yet after being brought back online. There are errors potentially from spack-stack and ecflow that are causing the compile tasks to immediately abort. The ecflow_run directory and files inside are not able to be found during the test run. Permissions for the generated directory and files inside seem fine, so there's something else going on there. |
Leaving another note that I had started testing yesterday, I'll update the baseline date on Hera and Gaea from 0613 to 0614. Just a heads up so there's no concern over the mismatched bl_date in the RT logs. |
Jet baseline creation was successful with rocoto, stack-python needs to be loaded within the Jet modulefile, otherwise lmod throws an error. I'll commit that once the Jet RTs are done. I'm also generating baselines for the 2-3 tests from the 0607 baseline as well to bring Jet baselines up to date, so it's going to take a bit. |
@WChen-NOAA could you add me as a collaborator for your ufs-weather-model fork/branch for this PR? |
Since we're skipping orion, we should be ready to proceed with merging. |
Commit Queue Requirements:
Fill out all sections of this template.
All sub component pull requests have been reviewed by their code managers.
Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
RegressionTests_hera.log
Commit 'test_changes.list' from previous step
Description:
This PR fix issue #2282 (related to #2173) . The changes are to allow compatibility for WAM regression tests with GFS_v17_p8. Changes have been made to the regression tests for this update.
wam_v17.nml.IN is based on the new global template namelist for the RTs. Variable values have been set to fit for WAM RTs.
diag_table_wam and field_table_wam_noaer are updated accordingly.
The warm-start RTs are replaced with cold-start RTs and the ICs are replaced with cold start ICs.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
control_wam
control_wam_debug
Input data Changes:
FV3_input_data_L149
on HERA soft links are made for RTs, use
export INPUTDATA_ROOT=/scratch1/NCEPDEV/stmp2/Wen.Chen/FV3WAM
before running tests
Library Changes/Upgrades:
Testing Log: