-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CICE end of run restart file capability+Update submodule FV3/atmos_cubed_sphere to fix a typo when printing out the nest grid corner locations #2323+Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UsersGuide #2329 + Orion changes for switch to new OS - Rocky-9 #2336 #2324
Add CICE end of run restart file capability+Update submodule FV3/atmos_cubed_sphere to fix a typo when printing out the nest grid corner locations #2323+Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UsersGuide #2329 + Orion changes for switch to new OS - Rocky-9 #2336 #2324
Conversation
The CICE hash includes changed that will add the ability to write a restart file at the end of the run via the CMEPS configuration. This is in conjunction with a similar PR for the MOM6 model.
@dpsarmie Since at this point we'd have the capability to turn this for CMEPS, CICE and MOM6, we'd want to add a configurable setting to the various ufs.configure files. We can set that false by default, but that will allow the G-W to set it optionally .true. |
There were multiple regression tests that did not have the write_restart_at_endofrun option in the ufs.configure file. Now that the write_restart_at_endofrun has been fixed in MOM6 and CICE, this option will be added to the ufs.configure files. This does not cause change the RT baselines.
Adding the write_restart_at_endofrun option to other regression test ufs.configure files that were missed with the previous commit.
@DeniseWorthen That makes sense. The change will be rolled into this PR. The ufs.configure files have been changed and retested everything for completeness. |
@dpsarmie We need this as a configurable variable, so that users can set it true if they need to but we can use false in the RT. |
This will change the write_restart_at_endofrun variable to @[WRITE_ENDOFRUN_RESTART] to allow for user configuration. Default has been set to .false. in default_vars.sh.
@dpsarmie Thanks for making those changes. I think this is ready. |
2 minor typos fixed in default_var script comments
@DeniseWorthen Ok great! The RTs just finished on Hercules using the latest version of the branch and it was good to go on my end. |
@dpsarmie can you sync up branches? We like to start working on this pr. Can you combine in #2323 to this pr? Just need to points to @BinLiu-NOAA 's fv3 feature branch: NOAA-EMC/fv3atm#847 |
This will point to changes in FV3 submodule that are a part of PR ufs-community#2323.
This will merge changes made in the FV3 submodule as part of PR#2323 into this PR. FV3 source: https://github.com/hafs-community/fv3atm/tree/feature/grid_corner_jc_fix
…sarmie/ufs-weather-model into feature/CICE_endofrun_restart
Point to FV3 submodule on https://github.com/hafs-community/fv3atm/tree/feature/grid_corner_jc_fix
@jkbk2004 I just want ahead and edited the gitmodules file to point to Bin's branch and brought the PR up to date. Let me know if you need anything else. |
@dpsarmie I'm not seeing Bin's latest commit in your FV3, only the latest fv3 develop commit of 07c26d1 which does not look like it contains Bin's newer a6fdff7 for atmos cubed sphere. Could you double check your hashes for fv3/atmos cubed sphere?
|
Revert unintended change
@FernandoAndrade-NOAA Sorry, I had it in 1561588 but then overwrote it back with the e5b9eed commit. Looks like Jong made the update to the hash. Thanks Jong! |
All looks good. @FernandoAndrade-NOAA This PR is ready for testing. @zach1221 I will check if I can run on Orion. @BrianCurtis-NOAA FYI |
Apologies for the delay. Please see rundir below for failed case. |
@zach1221 I think you misunderstood. You said that you could confirm that the other debug tests ran OK on derecho. Where are those rundirs located? |
Sure, location is here. |
@jkbk2004 We are OK disabling that test on Derecho and moving forward. Please create an issue with all we've learned about the problem so we can follow up on fixing it. |
@dpsarmie @zach1221 can we create git issue to follow on derecho cpld_debug_gfsv17_intel failure ? We can turn off the case on derecho and go for merging. @BrianCurtis-NOAA @DeniseWorthen would it be ok? |
@BrianCurtis-NOAA Thanks! |
Sorry for the delay. But we can move on for merging process with cpld_debug_gfsv17_intel disabled on derecho. |
@jkbk2004 We don't have a derecho log yet. |
Ok I think we're set to continue, the failed test in the Derecho log has already been disabled in a previous commit. |
CICE has been merged hash 9452de8 |
The CICE hash includes changed that will add the ability to write a restart file at the end of the run via the CMEPS configuration. This is in conjunction with a similar PR for the MOM6 model.
Commit Queue Requirements:
Description:
This PR adds changes to the CICE submodule that allows for the creation of restart files at the end of the model run. This option is controlled in CMEPS via the write_restart_at_endofrun config option. This should allow for files to be written when the interval write time does not sync up with the total run time (ex. 27h forecast with 12h restart write intervals). This change was also done in another PR for MOM6.
Commit Message:
Priority:
Git Tracking
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: