-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/public-v2: update build.sh for macOS, update regression tests, update modulefiles #248
release/public-v2: update build.sh for macOS, update regression tests, update modulefiles #248
Conversation
…u.cmake to CMakeLists.txt so that it works with build.sh; update build.sh to usee correct readlink command on macOS
… for regression tests
9385099
to
2976d52
Compare
@climbfuji When I attempt to build the ufs-weather-model as part of the ufs-srweather-app, I run into an error in the ccpp prebuild step:
I was initially curious if maybe this was related to my python environment, but I do not see this error when building the release branch. I also attached the cmake log referenced above but it doesn't seem to have any useful information. Let me know if you need any more info. Oh and this is on MacOS High Sierra, by the way. |
Please look in these files: |
That was indeed the issue, sorry I missed those log files. It looks like the ufs-srweather-app needs to be updated to only build the supported suites, I can open a PR for that. When I make that change it now compiles for gnu-10 compilers on my High Sierra machine! I think I just need to make an update to UFS_UTILS to include the same flags and the full app will build. Thanks for working on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please point fv3 back to release/public-v2, then we can merge the code.
Done, please check. Thanks! |
modified file: ush/templates/FV3.input.yml Co-authored-by: Linlin.Pan <Linlin.Pan@noaa.gov>
Description
This PR:
cmake/configure_macosx.gnu.cmake
toCMakeLists.txt
so that it works withbuild.sh
build.sh
to use the correctreadlink
command on macOStests/rt.conf
to run regression tests specific to the SRW Appparm
,tests/fv3_conf
,tests/tests
Caveats:
tests/rt.conf
with a short note about the failurert_gnu.conf
andrt_jet_intel.conf
for systems that have problems with more testsTesting
New baselines will be created on most tier-1 platforms of the SRW App release (hera.intel, hera.gnu, cheyenne.intel, cheyenne.gnu, jet.intel, gaea.intel; gaea.intel may be skipped if cluster problems are not resolved in time)
UPDATE:
Dependencies
NOAA-EMC/fv3atm#190
#248