Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new PBL diagnostic variables dkt and dku #505

Merged
merged 18 commits into from
Apr 21, 2021
Merged

Add new PBL diagnostic variables dkt and dku #505

merged 18 commits into from
Apr 21, 2021

Conversation

BinLiu-NOAA
Copy link
Contributor

@BinLiu-NOAA BinLiu-NOAA commented Apr 2, 2021 •
edited by BrianCurtis-NOAA
Loading

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR adds new PBL diagnostic variables dkt and dku (atmosphere heat and momentum diffusivity) used in HAFS. This PR should not change answers, neither require any library or module updates.

Issue(s) addressed

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
    - [ ] jet.intel NOTE: SKIPPED DUE TO JET PM
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@BinLiu-NOAA BinLiu-NOAA added No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Apr 2, 2021
This was referenced Apr 2, 2021
Merged
Merged
@BinLiu-NOAA BinLiu-NOAA marked this pull request as ready for review April 2, 2021 16:04
@BinLiu-NOAA
Copy link
Contributor Author

ufs-weather-model regression tests on Hera have passed successfully.

@BinLiu-NOAA BinLiu-NOAA changed the title Add a new PBL diagnostic variable dkudiagnostic Add new PBL diagnostic variables dkt and dku Apr 16, 2021
@BinLiu-NOAA BinLiu-NOAA mentioned this pull request Apr 19, 2021
Merged
@BrianCurtis-NOAA
Copy link
Collaborator

Good morning @BinLiu-NOAA , you're on top of the commit queue now. Could you please bring your ufs-weather-model fork up-to-date with ufs-weather-model/develop and make sure your FV3 fork is also up-to-date with fv3atm/develop? Thank you.

@climbfuji
Copy link
Collaborator

Good morning @BinLiu-NOAA , you're on top of the commit queue now. Could you please bring your ufs-weather-model fork up-to-date with ufs-weather-model/develop and make sure your FV3 fork is also up-to-date with fv3atm/develop? Thank you.

@BrianCurtis-NOAA please note the comment I left in the fv3atm PR that needs to be addressed (in addition to updating to the head of the authoritative branches): NOAA-EMC/fv3atm#269 (comment)

@BrianCurtis-NOAA
Copy link
Collaborator

Good morning @BinLiu-NOAA , you're on top of the commit queue now. Could you please bring your ufs-weather-model fork up-to-date with ufs-weather-model/develop and make sure your FV3 fork is also up-to-date with fv3atm/develop? Thank you.

@BrianCurtis-NOAA please note the comment I left in the fv3atm PR that needs to be addressed (in addition to updating to the head of the authoritative branches): NOAA-EMC/fv3atm#269 (comment)

Yes, make sure you fix the fv3atm issue and update the pointer here afterwards. Thanks Dom.

@BrianCurtis-NOAA
Copy link
Collaborator

BrianCurtis-NOAA commented Apr 20, 2021 •
edited
Loading

Don't forget to bring this branch up-to-date with ufs-community/ufs-weather-model: develop after you bring your fv3atm branch up-to-date as well.

@BinLiu-NOAA
Copy link
Contributor Author

@BrianCurtis-NOAA I am working on to bring this branch up to date with the latest develop branch. It is currently 1-2 commits behind. Will let you know once it's done. Should be done shortly. Thanks!

@BinLiu-NOAA
Copy link
Contributor Author

@BrianCurtis-NOAA I looked one of the failed test err log:
/gpfs/hps3/stmp/Brian.Curtis/FV3_RT/rt_13270/fv3_thompson_no_aero_debug/err
in fcst run phase 2, na= 35
forrtl: Device or resource busy
forrtl: severe (38): error during write, unit 50, file /gpfs/hps3/stmp/Brian.Curtis/FV3_RT/rt_13270/fv3_thompson_no_aero_debug/PET120.ESMF_LogFile
Image PC Routine Line Source
fv3.exe 000000000B46229E Unknown Unknown Unknown
fv3.exe 000000000B4C9240 Unknown Unknown Unknown
fv3.exe 000000000B4C48E8 Unknown Unknown Unknown
fv3.exe 0000000001503AC2 esmf_logerrmod_mp 1011 ESMF_LogErr.F90
fv3.exe 000000000151334A esmf_logerrmod_mp 2736 ESMF_LogErr.F90
fv3.exe 00000000014FEA9F f_esmf_logwrite0_ 40 ESMF_LogErr_C.F90
fv3.exe 000000000064FF8C _ZN5ESMCI6LogErr5 350 ESMCI_LogErr.C
fv3.exe 000000000069799E _ZN5ESMCI2VM10log 2497 ESMCI_VM.C
fv3.exe 0000000001DF4940 c_esmc_vmlogmemin 2078 ESMCI_VM_F.C
fv3.exe 000000000169FBEF esmf_vmmod_mp_esm 6008 ESMF_VM.F90
fv3.exe 0000000002DFAC3B fv3gfs_cap_mod_mp 1223 fv3_cap.F90

By any chance, there might be system side issue (file system, io, wallclock limit, etc.), which could have caused the failure?

@BrianCurtis-NOAA
Copy link
Collaborator

It's very possible. Once my Dell P3 run is done i'll retry the cray.

@BrianCurtis-NOAA
Copy link
Collaborator

Machine: hera
Compiler: intel
Job: RT
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/608013381/20210420230014/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_237457
Test datm_bulk_cfsr 105 failed failed
Test datm_bulk_cfsr 105 failed in run_test failed
Please make changes and add the following label back:
hera-intel-RT

@BrianCurtis-NOAA
Copy link
Collaborator

hera intel test error was a slurm issue, nothing related to the RT's, I'm re-running that one test and will add it to the log

@BrianCurtis-NOAA
Copy link
Collaborator

@MinsukJi-NOAA i'm not sure if the issue showing for the failed run-ci tests is something we should be concerned about. Do we need to change anything?

@MinsukJi-NOAA
Copy link
Contributor

@MinsukJi-NOAA i'm not sure if the issue showing for the failed run-ci tests is something we should be concerned about. Do we need to change anything?

@BrianCurtis-NOAA this is an ec2/docker issue and not a testing issue, and i suggest going ahead with the PR. I expect this issue to be fixed with an upcoming PR.

@BrianCurtis-NOAA
Copy link
Collaborator

@MinsukJi-NOAA Thanks!

I'm just waiting on the failed test to re-run on hera.intel, still sitting in pending

junwang-noaa
junwang-noaa approved these changes Apr 21, 2021
View reviewed changes
Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code can be committed once all RT (except jet) is done and the FV3 repo is updated.

@BrianCurtis-NOAA
Copy link
Collaborator

FV3 PR is merged. Please revert .gitmodules and update pointer to NOAA-EMC:develop

@BinLiu-NOAA
Copy link
Contributor Author

@BrianCurtis-NOAA, Done to revert .gitmodules and update pointer to NOAA-EMC:develop. Please double check.
Thanks!

@BrianCurtis-NOAA
Copy link
Collaborator

The hash's match. Waiting on @climbfuji approval.

@climbfuji climbfuji merged commit 5096d5f into ufs-community:develop Apr 21, 2021
@BinLiu-NOAA BinLiu-NOAA deleted the feature/dkudiagnostic branch June 29, 2021 16:52
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
@WenMeng-NOAA
update upp revision (ufs-community#505)
55e98b2
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
@christinaholtNOAA
[develop] Refactor setup.py to remove use of global variables. (#505)
bf07542 
Global variable use has been removed in setup.py, and reduced in generate_FV3LAM_wflow.py. The use of globals is a carry-over from the bash era of this utility, and does not meet modern coding standards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@climbfuji climbfuji climbfuji approved these changes

Assignees

@BinLiu-NOAA BinLiu-NOAA

@BrianCurtis-NOAA BrianCurtis-NOAA

Labels
No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BinLiu-NOAA @BrianCurtis-NOAA @climbfuji @MinsukJi-NOAA @junwang-noaa @DusanJovic-NOAA