Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates from v2 release branch #521

Merged
merged 27 commits into from
Apr 26, 2021
Merged

Updates from v2 release branch #521

merged 27 commits into from
Apr 26, 2021

Conversation

llpcarson
Copy link
Collaborator

@llpcarson llpcarson commented Apr 14, 2021 •
edited by climbfuji
Loading

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR includes updates to the documentation of the ufs-weather-model, developed as part of the v2.0.0 release, and a few bug fixes that were also part of that release.

ufs-weather-model: doc/ subdirectory, add the RRFS_v1alpha to rt.conf
NEMS: doc directory only
fv3atm: add RRFS_v1alpha SDF
ccpp-physics: documentation, fix assumed-size array dimentions (gnu10 fix), rename gmtb-scm to scm (Single Column Model)
atmos_cubed_sphere: doc directory only

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.

Testing

Regression tests are running now (cheyenne.intel complete), with no change to the existing baselines. A new baseline is needed for the RRFS_v1alpha tests.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

NOAA-EMC/NEMS#96
NOAA-EMC/fv3atm#280
NOAA-GFDL/GFDL_atmos_cubed_sphere#94
NCAR/ccpp-physics#626

This was referenced Apr 14, 2021
Merged
Merged
Merged
Merged
@climbfuji climbfuji added Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Apr 20, 2021
@BrianCurtis-NOAA
Copy link
Collaborator

Machine: cheyenne
Compiler: gnu
Job: RT
Repo location: /glade/work/briancurtis/git/BrianCurtis-NOAA/ufs-weather-model/tests/auto/pr/615573223/20210423090008/ufs-weather-model
Please manually delete: /glade/scratch/briancurtis/FV3_RT/rt_33012
Test fv3_thompson_no_aero_debug 023 failed in check_result failed
Test fv3_thompson_no_aero_debug 023 failed in run_test failed
Please make changes and add the following label back:
cheyenne-gnu-RT

climbfuji
climbfuji reviewed Apr 24, 2021
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, will approve when submodule pointers are updated.

@BrianCurtis-NOAA
Copy link
Collaborator

Dell p3 stuck in pending. I'll post in AM, if you want to grab log when done: /gpfs/dell2/emc/modeling/noscrub/Brian.Curtis/git/llpcarson/ufs-weather-model/tests

@junwang-noaa
Copy link
Collaborator

@llpcarson I put the dell log file Brian created to hera at: /scratch1/NCEPDEV/stmp2/Jun.Wang/wcosslog/RegressionTests_wcoss_dell_p3.log

@llpcarson
Copy link
Collaborator Author

llpcarson commented Apr 25, 2021 via email

@climbfuji
Copy link
Collaborator

All tier-1 regression tests passed. I just pushed an empty commit "run-ci" to trigger the CI tests. In the meanwhile, I will merge ccpp-physics.

@climbfuji
Copy link
Collaborator

ci tests passed for commit fdfb661.

@DusanJovic-NOAA DusanJovic-NOAA merged commit dfabe21 into ufs-community:develop Apr 26, 2021
@llpcarson llpcarson mentioned this pull request Jun 2, 2021
Closed
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
@WenMeng-NOAA
Unify inline post (ufs-community#521)
6ee5395 
* Unify global and regional inline posts and add bug fix for dx/dy computation.
* Update upp revision to dc8bc68
* Set up different configurations of read max/min 2m T for global and regional FV3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@climbfuji climbfuji climbfuji approved these changes

Assignees
No one assigned
Labels
Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring documentation from UFS release branch to dev/emc Update documentation of the UFS weather model
5 participants
@llpcarson @BrianCurtis-NOAA @junwang-noaa @climbfuji @DusanJovic-NOAA