Use prebuilt FMS library #534
Conversation
DusanJovic-NOAA
requested review from
aerorahul,
junwang-noaa,
climbfuji and
DeniseWorthen
|
Should you also do a |
Yes. Thanks. |
| @@ -1,12 +0,0 @@ | |||
| --- FMS/mpp/include/mpp_util_mpi.inc 2021-02-08 08:24:21.000000000 -0700 | |||
| +++ FMS/mpp/include/mpp_util_mpi.inc 2021-02-08 08:24:15.000000000 -0700 | |||
There was a problem hiding this comment.
So this patch is no longer needed or is moved to fms library?
There was a problem hiding this comment.
We don't know until we try. If it is still needed, it will have to go to hpc-stack so that we have it under our own control.
There was a problem hiding this comment.
It will be difficult to apply inside of hpc-stack build_fms.sh.
There are no machine specific conditionals in any of these build scripts.
|
I was thinking of doing that inside config/config_cheyenne_gnu-9.sh if needed.
… On Apr 20, 2021, at 7:16 AM, Rahul Mahajan ***@***.***> wrote:
@aerorahul commented on this pull request.
In cheyenne_gnu_fms_mpp_util_mpi_inc.patch <#534 (comment)>:
> @@ -1,12 +0,0 @@
---- FMS/mpp/include/mpp_util_mpi.inc 2021-02-08 08:24:21.000000000 -0700
-+++ FMS/mpp/include/mpp_util_mpi.inc 2021-02-08 08:24:15.000000000 -0700
It will be difficult to apply inside of hpc-stack build_fms.sh.
There are no machine specific conditionals in any of these build scripts.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#534 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RIWBTPKV6JJCIAVDBLTJV5ETANCNFSM43GMRZXA>.
|
If you can do that, that would be great. |
1 similar comment
If you can do that, that would be great. |
|
There is no reason to "pollute" build_fms for something that appears to be a bug on a specific machine (or MPI+COMPILER combination). Let's check first if the patch is still needed, though.
… On Apr 20, 2021, at 7:21 AM, Rahul Mahajan ***@***.***> wrote:
I was thinking of doing that inside config/config_cheyenne_gnu-9.sh if needed.
On Apr 20, 2021, at 7:16 AM, Rahul Mahajan @.***> wrote:
@aerorahul <https://github.com/aerorahul> commented on this pull request.
In cheyenne_gnu_fms_mpp_util_mpi_inc.patch #534 (comment) <#534 (comment)>:
@@ -1,12 +0,0 @@
---- FMS/mpp/include/mpp_util_mpi.inc 2021-02-08 08:24:21.000000000 -0700
-+++ FMS/mpp/include/mpp_util_mpi.inc 2021-02-08 08:24:15.000000000 -0700
It will be difficult to apply inside of hpc-stack build_fms.sh.
There are no machine specific conditionals in any of these build scripts.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub #534 (comment) <#534 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5C2RIWBTPKV6JJCIAVDBLTJV5ETANCNFSM43GMRZXA <https://github.com/notifications/unsubscribe-auth/AB5C2RIWBTPKV6JJCIAVDBLTJV5ETANCNFSM43GMRZXA>.
If you can do that, that would be great.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#534 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2ROXL4MEPVBRR2EZHYDTJV5T5ANCNFSM43GMRZXA>.
|
|
@DusanJovic-NOAA, I made a PR to your libfms branch for CI update that is needed (#575) |
* Remove fms submodule check * Use an updated ubuntu-hpc container for fms library
|
Machine: orion |
|
Machine: jet |
|
Machine: orion |
|
Ready for merge. |
This adds support for 32-bit physics to the FV3, based on prior work on the Neptune model. Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This PR removes FMS git submodule, and updates module files and top-level CMakeLists.txt to use fms module (library) built by hpc-stack.
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Requires new baselines.