Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utest and add regional tests to ci #560

Closed

Conversation

MinsukJi-NOAA
Copy link
Contributor

@MinsukJi-NOAA MinsukJi-NOAA commented May 6, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Update utest to handle regional model runs.
Add regional model to CI

Issue(s) addressed

#543 . There will be a follow-up PR that will complete #543.

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

None

@MinsukJi-NOAA
Copy link
Contributor Author

@DeniseWorthen @junwang-noaa Does the cpld model run using gnu compiler? I tried to run cpld_control, but it failed: https://github.com/ufs-community/ufs-weather-model/runs/2527075480?check_suite_focus=true#step:5:867
Using the same codes, I was able to finish running on Hera using Intel compiler. BTW, I do not see a test case in rt_gnu.conf.

@github-actions github-actions bot removed the run-ci label May 25, 2021
@MinsukJi-NOAA MinsukJi-NOAA changed the title Update utest and add cpld and regional tests to ci (draft) Update utest and add regional tests to ci May 25, 2021
@MinsukJi-NOAA
Copy link
Contributor Author

@MinsukJi-NOAA
Copy link
Contributor Author

Code changes in this PR will be made via another PR #603

@MinsukJi-NOAA MinsukJi-NOAA mentioned this pull request May 27, 2021
13 tasks
@MinsukJi-NOAA MinsukJi-NOAA deleted the feature/utest-update branch June 3, 2021 17:23
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model that referenced this pull request Apr 4, 2023
* Switch to fms2 io
* Model should fail in post_namelist is missing or there's an error during read
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Currently the domain to plot is hard-coded to conus in the plotting scripts. This PR adds the capability to choose either conus or regional or both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant