-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physics update in cumulus convection, PBL & surface layer for UFS_P7; update compiler versions on Cheyenne #592
Conversation
The control_2threads was a timeout. Went past 15 minutes wall clock. |
@JongilHan66 Have you completed the hera.intel RT? |
It failed due to time limit in compile_002. Since it passed when creating the new baselines, I've just re-submitted the RT run against the new baselines. |
The compile_002 which was the only problem in the hera.intel RT has just passed in re-submission. |
Copy the log file of the one test that passed into the end of the log file with the one test failed and commit it. So we have a record that all tests passed on Hera.intel |
Unfortunately, the previous log file was deleted and so I have to wait for the new log file until all the RT runs are completed. |
This reverts commit 9e758fe.
Need to wait for hera.intel RT to pass, otherwise looks good. Thanks for including the CHeyenne Intel and GNU compiler updates. Good to see the model being tested with Intel 2021.2 and GNU 10.1. |
Regression testing on hera.intel@JongilHan66 ran The regression test log from @JongilHan66 got deleted. @climbfuji reran RegressionTests_hera.intel.log The UFS code managers agreed to consider this as sufficient for merging the PRs. |
…closure for the P8 physics suite) (ufs-community#592) * This is equivalent to PR66 in NCAR/fv3atm: NCAR/main PR ufs-community#66 (Bugfix and optimization of prognostic closure for the P8 physics suite)
Cumulus convection:
a) More strict convection trigger
b) Reduced entrainment rate below cloud base
c) Enhanced downdraft detrainments starting from 60mb above the ground surface
d) Reduced rain evaporation
e) Modification of cloud depth separating shallow convection from deep convection
PBL and surface layer:
a) Inclusion of wind shear effect reducing characteristic mixing length
b) Reduction of background diffusivity in the inversion layers as a function of surface roughness and green vegetation fraction
c) PBL updraft overshooting limited by bulk Richardson number-based-PBL depth
d) Inclusion of new canopy heat storage parameterization
e) Modification of thermal roughness calculation over land
f) Increase of momentum roughness length over sea
g) Inclusion of sea spray effect parameterization
The verification results for the physics updates above can be found in https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/ccaa14
More detailed description for the updates and ccaa14 results are given in the attached ppt file.
Tests_physics_MRF_MJO_JHan_WLi.pptx
Verification results for additional physics updates are in:
Winter: https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/ccaa41
Summer: https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/ccaa41x
The final update is based on 'ccaa41'.
Description for the new maximum z/L parameterization can be found in the attached ppt file.
PBL_SL_inv_JHan.pptx
This PR includes all the changes from PR https://github.com/ufs-community/ufs-weather-model/pull/672/commits, "Update GNU and Intel compiler versions on Cheyenne, don't run control_debug_2threads when creating baselines"
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
Resolves #588
Depends NCAR/ccpp-physics#665
Depends NOAA-EMC/fv3atm#314