Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address memory leak in cellular automaton scheme #755

Closed

Conversation

lisa-bengtsson
Copy link
Contributor

@lisa-bengtsson lisa-bengtsson commented Aug 20, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Bugfix for memory leak in cellular automaton scheme

Issue(s) addressed

Issue 746

Testing

Runs with UFS tagged P7c confirmed memory leak is fixed with this update, as well as unit tests with CA scheme on Hera.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI

Dependencies

Do PRs in upstream repositories need to be merged first?

  • waiting on noaa-psd/stochastic_physics/pull/<44>

NOAA-PSL/stochastic_physics#44

@github-actions
Copy link

@lisa-bengtsson please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date

@DeniseWorthen
Copy link
Collaborator

Code will be committed as part of PR #756

DeniseWorthen added a commit that referenced this pull request Aug 23, 2021
…sics (was PR #755) (#756)


* update CICE for added memory profiling
* update stochastic_physics for memory fix leak

co-authors: @lisa-bengtsson , @pjpegion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants