Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates for FV3 "the dycore" and run templates, parm/field_table/* updated for RTS #870

Merged
merged 24 commits into from
Oct 19, 2021
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
01d40af
move field_table to tests/parm/field_table directory
junwang-noaa Oct 13, 2021
e40f18d
add gocart field_table
junwang-noaa Oct 13, 2021
67e6d32
fix the datm test
junwang-noaa Oct 13, 2021
c7e6f2d
update field_table from parm directory for gsd tests
junwang-noaa Oct 14, 2021
c480414
not update intel log file
junwang-noaa Oct 14, 2021
7725797
changed initial profile values for tracers in parm/field_table/*
bensonr Oct 15, 2021
6e9cbf1
added --exclude 'field_table' to rsync command for run templates in t…
bensonr Oct 15, 2021
20defbd
updated .gitmodule to point have FV3 point to bensonr/fv3atm::dycore
bensonr Oct 15, 2021
56e1587
updating FV3 to point to bensonr/fv3atm 50dcff0 hash
bensonr Oct 15, 2021
6e3d15a
removed obsoleted if-test in tests/fv3_conf/hafs_regional_run.IN
bensonr Oct 18, 2021
5e50c18
Merge remote-tracking branch 'ufs/develop' into field_table
bensonr Oct 18, 2021
7ebc4ef
remove DATM
bensonr Oct 18, 2021
31550ac
updating module CDEPS to be in sync with develop branch
bensonr Oct 18, 2021
a0edd91
RT JOBS PASSED: hera.gnu. Log file uploaded.
BrianCurtis-NOAA Oct 18, 2021
109e019
RT JOBS PASSED: orion.intel. Log file uploaded.
BrianCurtis-NOAA Oct 18, 2021
ba6e757
RT JOBS PASSED: cheyenne.intel. Log file uploaded.
BrianCurtis-NOAA Oct 18, 2021
d569558
insert wcoss dell_p3 & cray RTS logs
bensonr Oct 18, 2021
ae85e89
updating tests/ci/repo_check.sh as directed by @MinsukJi-NOAA
bensonr Oct 18, 2021
f68b5c4
Regression test log for cheyenne.gnu
BrianCurtis-NOAA Oct 18, 2021
c6f0bf1
add jet.intel log
DeniseWorthen Oct 18, 2021
a489bd5
modify tests/parm/field_table/field_table_GOCART to force initialize …
bensonr Oct 19, 2021
d931713
update hera intel log file
BrianCurtis-NOAA Oct 19, 2021
54acbd2
update gaea log file
BrianCurtis-NOAA Oct 19, 2021
5584e51
reverting .gitmodules for FV3 path and updating FV3 submodule to poin…
bensonr Oct 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
url = https://github.com/bensonr/fv3atm
branch = dycore
[submodule "NEMS"]
path = NEMS
url = https://github.com/NOAA-EMC/NEMS
Expand Down
2 changes: 1 addition & 1 deletion FV3
Submodule FV3 updated 1 files
+1 −1 atmos_cubed_sphere
378 changes: 187 additions & 191 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

382 changes: 191 additions & 191 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

515 changes: 264 additions & 251 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

150 changes: 75 additions & 75 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

504 changes: 289 additions & 215 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

611 changes: 312 additions & 299 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

394 changes: 197 additions & 197 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

244 changes: 122 additions & 122 deletions tests/RegressionTests_wcoss_cray.log

Large diffs are not rendered by default.

486 changes: 180 additions & 306 deletions tests/RegressionTests_wcoss_dell_p3.log

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions tests/ci/repo_check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ result() {
}

# Declare variables
declare -A base fv3 mom6 cice ww3 stoch gocart nems cmeps cdeps cmake
submodules="fv3 mom6 cice ww3 stoch gocart nems cmeps cdeps cmake"
declare -A base fv3 mom6 cice ww3 stoch gocart nems cmeps cdeps hycom cmake
submodules="fv3 mom6 cice ww3 stoch gocart nems cmeps cdeps hycom cmake"
comment=''
ownerID=$1

Expand Down Expand Up @@ -60,7 +60,7 @@ cdeps[branch]='develop'
cdeps[dir]='CDEPS-interface/CDEPS'

hycom[repo]='https://github.com/NOAA-EMC/HYCOM-src'
hycom[branch]='develop'
hycom[branch]='emc/develop'
hycom[dir]='HYCOM-interface/HYCOM'

cmake[repo]='https://github.com/NOAA-EMC/CMakeModules'
Expand Down
4 changes: 3 additions & 1 deletion tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,9 @@ export NBITS=0
export IMO=384
export JMO=190

#input file
export FIELD_TABLE=field_table_gfsv16

# Coldstart/warmstart
#rt script for ICs
export MODEL_INITIALIZATION=false
Expand Down Expand Up @@ -933,7 +936,6 @@ export flux_scheme=0

export INPUT_NML=input.mom6.nml.IN
export MODEL_CONFIGURE=datm_cdeps_configure.IN
export FIELD_TABLE=field_table
export DIAG_TABLE=diag_table_template

# atm defaults
Expand Down
26 changes: 1 addition & 25 deletions tests/fv3_conf/c96_HAFS_v0_hwrf_run.IN
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ cp @[INPUTDATA_ROOT]/FV3_input_data/INPUT/solarconstant_noaa_an.txt .
cp @[INPUTDATA_ROOT]/FV3_input_data/ozprdlos_2015_new_sbuvO3_tclm15_nuchem.f77 ./global_o3prdlos.f77
cp @[INPUTDATA_ROOT]/FV3_input_data/global_h2o_pltc.f77 ./global_h2oprdlos.f77
cp @[INPUTDATA_ROOT]/FV3_input_data/*grb .
cp @[INPUTDATA_ROOT]/FV3_input_data/*_table .
cp @[INPUTDATA_ROOT]/FV3_input_data/diag_table .

# Copy landuse/soil/vegetation parameter tables for HWRF Noah LSM
cp @[INPUTDATA_ROOT]/FV3_input_data_hafs/GENPARM.TBL .
Expand All @@ -49,30 +49,6 @@ else
exit 1
fi

# Copy field table, depending on microphysics choice and whether MYNN/SATMEDMF is used
if [ $IMP_PHYSICS = 8 ]; then
if [ $LTAEROSOL = .true. ]; then
if [ $DO_MYNNEDMF = .true. ] || [ $SATMEDMF = .true. ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_gsd field_table
else
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_gf_thompson field_table
fi
else
if [ $DO_MYNNEDMF = .true. ] || [ $SATMEDMF = .true. ]; then
echo "ERROR, no field table configured for Thompson MP without aerosols but with MYNN or SATMEDMF (need TKE)"
exit 1
else
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_thompson_noaero field_table
fi
fi
elif [ $IMP_PHYSICS = 15 ]; then
# Copy field table for Ferrier-Aligo MP
cp @[INPUTDATA_ROOT]/FV3_input_data_hafs/field_table_FA_nwat4 field_table
else
echo "ERROR, no field table configured for IMP_PHYSICS=${IMP_PHYSICS}"
exit 1
fi

# Thompson or F-A MP lookup tables
if [ $IMP_PHYSICS = 8 ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/qr_acr_qsV2.dat .
Expand Down
19 changes: 0 additions & 19 deletions tests/fv3_conf/control_run.IN
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,11 @@ else
cp @[INPUTDATA_ROOT]/${inputdir}/*grb .
fi
cp @[INPUTDATA_ROOT]/${inputdir}/diag_table_gfsv16 ./diag_table
cp @[INPUTDATA_ROOT]/${inputdir}/field_table_gfsv16 ./field_table

if [ $NEW_DIAGTABLE != 'none' ]; then
cp @[INPUTDATA_ROOT]/${inputdir}/$NEW_DIAGTABLE ./diag_table
fi

if [ $NEW_FIELDTABLE != 'none' ]; then
cp @[INPUTDATA_ROOT]/${inputdir}/$NEW_FIELDTABLE ./field_table
fi

if [ $CPLWAV = .true. ]; then
cp @[INPUTDATA_ROOT_WW3]/mod_def.* .
cp @[INPUTDATA_ROOT_WW3]/rmp_src* .
Expand Down Expand Up @@ -146,19 +141,6 @@ fi

#Thompson
if [ $IMP_PHYSICS = 8 ]; then
if [ $LTAEROSOL = .true. ]; then
if [ $DO_MYNNEDMF = .true. ] || [ $SATMEDMF = .true. ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_gsd field_table
else
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_gf_thompson field_table
fi
else
if [ $DO_MYNNEDMF = .true. ] || [ $SATMEDMF = .true. ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_thompson_noaero_tke field_table
else
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_thompson_noaero field_table
fi
fi
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/qr_acr_qsV2.dat .
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/qr_acr_qgV2.dat .
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/freezeH2O.dat .
Expand All @@ -168,7 +150,6 @@ fi
#prognostic aerosols
if [ $CPLCHM = .true. ]; then
cp ${PATHRT}/parm/gocart/diag_table .
cp ${PATHRT}/parm/gocart/field_table .
cp ${PATHRT}/parm/gocart/*.rc .
ln -sf @[INPUTDATA_ROOT]/GOCART/ExtData .
fi
1 change: 0 additions & 1 deletion tests/fv3_conf/cpld_control_run.IN
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ cp @[INPUTDATA_ROOT]/FV3_fix_tiled/@[ATMRES]/oro_@[ATMRES].mx@[OCNRES].tile5.
cp @[INPUTDATA_ROOT]/FV3_fix_tiled/@[ATMRES]/oro_@[ATMRES].mx@[OCNRES].tile6.nc INPUT/oro_data.tile6.nc
cp @[INPUTDATA_ROOT]/FV3_fix_tiled/@[ATMRES]/@[ATMRES]*.nc .

cp @[INPUTDATA_ROOT]/${FV3_DIR}/@[FIELD_TABLE] ./field_table
cp @[INPUTDATA_ROOT]/CPL_FIX/a@[ATMRES]o@[OCNRES]/grid_spec.nc ./INPUT
cp @[INPUTDATA_ROOT]/${FV3_DIR}/INPUT/@[ATMRES]_grid*.nc ./INPUT
cp @[INPUTDATA_ROOT]/${FV3_DIR}/INPUT/grid_spec.nc ./INPUT/@[ATMRES]_mosaic.nc
Expand Down
26 changes: 1 addition & 25 deletions tests/fv3_conf/esg_HAFS_v0_hwrf_run.IN
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ rm -fr INPUT RESTART
mkdir INPUT RESTART

if [ $WARM_START = .false. ]; then
rsync -av @[INPUTDATA_ROOT]/FV3_input_data_regional_esg/ ./
rsync -av --exclude 'field_table' @[INPUTDATA_ROOT]/FV3_input_data_regional_esg/ ./
else
echo "ERROR, warmstart runs not configured for regional HAFs runs on ESG grid"
exit 1
Expand All @@ -21,27 +21,3 @@ else
echo "ERROR, no diag table configured for IMP_PHYSICS=${IMP_PHYSICS}"
exit 1
fi

# Copy field table, depending on microphysics choice and whether MYNN/SATMEDMF is used
if [ $IMP_PHYSICS = 8 ]; then
if [ $LTAEROSOL = .true. ]; then
if [ $DO_MYNNEDMF = .true. ] || [ $SATMEDMF = .true. ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_gsd field_table
else
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_gf_thompson field_table
fi
else
if [ $DO_MYNNEDMF = .true. ] || [ $SATMEDMF = .true. ]; then
echo "ERROR, no field table configured for Thompson MP without aerosols but with MYNN or SATMEDMF (need TKE)"
exit 1
else
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_thompson_noaero field_table
fi
fi
elif [ $IMP_PHYSICS = 15 ]; then
# Copy field table for Ferrier-Aligo MP
cp @[INPUTDATA_ROOT]/FV3_input_data_hafs/field_table_FA_nwat4 field_table
else
echo "ERROR, no field table configured for IMP_PHYSICS=${IMP_PHYSICS}"
exit 1
fi
2 changes: 1 addition & 1 deletion tests/fv3_conf/fv3_stretched_run.IN
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

rsync -arv @[INPUTDATA_ROOT]/FV3_nest_input_data/. .
rsync -arv --exclude 'field_table' @[INPUTDATA_ROOT]/FV3_nest_input_data/. .
rm -rf INPUT RESTART
mkdir INPUT RESTART

Expand Down
22 changes: 0 additions & 22 deletions tests/fv3_conf/gfs_v15_run.IN

This file was deleted.

19 changes: 0 additions & 19 deletions tests/fv3_conf/gfs_v16_flake_run.IN

This file was deleted.

32 changes: 0 additions & 32 deletions tests/fv3_conf/gfs_v16_run.IN

This file was deleted.

23 changes: 0 additions & 23 deletions tests/fv3_conf/gfs_v16_run_c192L127.IN

This file was deleted.

31 changes: 0 additions & 31 deletions tests/fv3_conf/gfsv16_csawmg_run.IN

This file was deleted.

28 changes: 1 addition & 27 deletions tests/fv3_conf/gsd_run.IN
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ cp @[INPUTDATA_ROOT]/FV3_input_data/INPUT/solarconstant_noaa_an.txt .
cp @[INPUTDATA_ROOT]/FV3_input_data/ozprdlos_2015_new_sbuvO3_tclm15_nuchem.f77 ./global_o3prdlos.f77
cp @[INPUTDATA_ROOT]/FV3_input_data/global_h2o_pltc.f77 ./global_h2oprdlos.f77
cp @[INPUTDATA_ROOT]/FV3_input_data/*grb .
cp @[INPUTDATA_ROOT]/FV3_input_data/*_table .
cp @[INPUTDATA_ROOT]/FV3_input_data/diag_table .

# Copy diag table file depending on LSM
if [ $LSM = 1 ] || [ $LSM = 2 ]; then
Expand All @@ -29,32 +29,6 @@ elif [ $LSM = 3 ]; then
fi
fi

# Copy field table, depending on microphysics choice and whether MYNN/SATMEDMF is used
if [ $IMP_PHYSICS = 8 ]; then
if [ $LTAEROSOL = .true. ]; then
if [ $DO_MYNNEDMF = .true. ] || [ $SATMEDMF = .true. ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_gsd field_table
else
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_gf_thompson field_table
fi
else
if [ $DO_MYNNEDMF = .true. ] || [ $SATMEDMF = .true. ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_thompson_noaero_tke field_table
else
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_thompson_noaero field_table
fi
fi
elif [ $IMP_PHYSICS = 11 ]; then
if [ $DO_MYNNEDMF = .true. ] || [ $SATMEDMF = .true. ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/field_table_suite2 field_table
else
cp @[INPUTDATA_ROOT]/FV3_input_data/field_table_gfdlmp field_table
fi
else
echo "ERROR, no field table configured for IMP_PHYSICS=${IMP_PHYSICS}"
exit 1
fi

# Thompson MP lookup tables - copy standard and SIONlib tables of precomputed tables
if [ $IMP_PHYSICS = 8 ]; then
cp @[INPUTDATA_ROOT]/FV3_input_data_gsd/qr_acr_qsV2.dat .
Expand Down
2 changes: 1 addition & 1 deletion tests/fv3_conf/hafs_regional_run.IN
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
rm -rf INPUT RESTART
mkdir INPUT RESTART

rsync -arv @[INPUTDATA_ROOT]/FV3_hafs_regional_input_data/. .
rsync -arv --exclude 'field_table' @[INPUTDATA_ROOT]/FV3_hafs_regional_input_data/. .
2 changes: 1 addition & 1 deletion tests/fv3_conf/regional_run.IN
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
rsync -arv @[INPUTDATA_ROOT]/FV3_regional_input_data/. .
rsync -arv --exclude 'field_table' @[INPUTDATA_ROOT]/FV3_regional_input_data/. .
if [ $WRITE_DOPOST = .true. ]; then
cp @[INPUTDATA_ROOT]/FV3_regional_input_data/diag_table_lam ./diag_table
fi
Expand Down
2 changes: 1 addition & 1 deletion tests/fv3_conf/stretched_run.IN
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
rsync -arv @[INPUTDATA_ROOT]/FV3_nest_input_data/. .
rsync -arv --exclude 'field_table' @[INPUTDATA_ROOT]/FV3_nest_input_data/. .
rm -rf INPUT RESTART
mkdir INPUT RESTART

Expand Down
Loading