-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCPP framework (metadata parser) update, and update several units in CCPP metadata in fv3atm and ccpp-physics, use Python 3.6+ #907
Conversation
Automated RT Failure Notification |
Automated RT Failure Notification |
Automated RT Failure Notification |
The error on orion is new to me, all compile jobs failed with a slurm error:
|
Automated RT Failure Notification |
This test timed out:
Will rerun manually and append to log, then commit. |
…/github.com/climbfuji/ufs-weather-model into correct_ccpp_metadata_due_to_feature_capgen
Submodule pointer for fv3atm looks correct (c72ba60), please check and merge if satisfied. |
@DeniseWorthen is on leave for the rest of this week, I will remove her from the list of reviewers. |
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
With the metadata parser update in NCAR/ccpp-framework#415, a stricter checking of units will be enforced. This includes the replacement of "convenience units" such as
log(Pa)
with 1. Corresponding changes are made in ccpp-physics and fv3atm.The ccpp-framework update requires Python 3.6 or newer - load Python 3.7.9 modules on Cheyenne, all other platforms are already using 3.6 or newer.
No changes to the regression test results, no changes to the input data.
Issue(s) addressed
Fixes NCAR/ccpp-framework#416
Testing
Regression tests were run against the existing baselines on Hera with Intel and GNU at the tiime the PRs were created (11/09 and 11/10). All tests passed.
RegressionTests_hera.intel.log
RegressionTests_hera.gnu.log
Full regression tests will be run when it is time to commit:
Dependencies