[MGTL] Allow multiple bulk element ids in identify #2252
Conversation
|
Of course, it's my pleasure ! |
|
Here we go: an unstructured triangle mesh and a Y-line going through the domain (typical for river BCs). Additionally, an according prism mesh. PS: that's how it looks like |
| @@ -133,21 +133,8 @@ std::vector<std::size_t> identifySubdomainMeshElements( | |||
| OGS_FATAL( | |||
| "Expect exactly one element to be found in the bulk mesh."); | |||
There was a problem hiding this comment.
Is the error message still correct?
There was a problem hiding this comment.
Fixed: "exactly one" to at "least one".
If the lower dimensional elements are inside the bulk mesh, there is no unique bulk element associated with it, but multiple elements. In the case of unique elements, the behaviour didn't change. In the case of multiple elements, the bulk element ids are stored in the FieldData with accompanying CellData array 'number_bulk_elements'.
Meshes kindly provided by Thomas_TK @ github <thomas.kalbacher@ufz.de>
|
Looks good with triangle mesh. . .will test it for prism meshes as well |
|
I works for the 3D prism model as well. !!!! |
|
I tested triangles, line elements and individual points as elements on a triangle and prism mesh. Works very well as BCs inside the domain. |
|
Put it in a ctest and add some docu on the benchmark page. Then, and only then, can you rely on these features being correct in the feature. |
|
OpenGeoSys development has been moved to GitLab. |
Upon request for Dirichlet BCs inside of the domain defined along lines.
@Thomas-TK Could you provide an example?