Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Robin / Neumann boundary conditions to user needs. #2710

Merged
merged 7 commits into from
Dec 3, 2019
Merged

Adapt Robin / Neumann boundary conditions to user needs. #2710

merged 7 commits into from
Dec 3, 2019

Conversation

TomFischer
Copy link
Member

@TomFischer TomFischer commented Nov 7, 2019 •
edited
Loading

Add possibility to specify 'lower' dimensional Robin/Neumann boundary conditions.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behavior change was documented?

endJunction
endJunction approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@endJunction endJunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!
Someone please check the ctests.

@TomFischer
Copy link
Member Author

Rebased and changed tolerances in ctests.

@endJunction
Copy link
Member

Please review.

@TomFischer
Copy link
Member Author

Rebased again. Please a second reviewer!

wenqing
wenqing approved these changes Nov 14, 2019
View reviewed changes
ProcessLib/BoundaryCondition/RobinBoundaryConditionLocalAssembler.h
double integral_measure = 1.0;
if (_data.integral_measure)
{
integral_measure = (*_data.integral_measure)(t, position)[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
integral_measure = (*_data.integral_measure)(t, position)[0];
const double integral_measure = (_data.integral_measure) ? (*_data.integral_measure)(t, position)[0] : 1.0;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't declare/define the variable integral_measure only in the scope of the branch of the if condition since it is used below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏩

ProcessLib/BoundaryCondition/NeumannBoundaryConditionLocalAssembler.h
ip_data.weight;
if (_data.integral_measure)
{
integral_measure = (*_data.integral_measure)(t, position)[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
integral_measure = (*_data.integral_measure)(t, position)[0];
const double integral_measure = (_data.integral_measure) ? (*_data.integral_measure)(t, position)[0] : 1.0;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't work. See the argument in the RobinBoundaryConditionLocalAssembler case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

ProcessLib/BoundaryCondition/NeumannBoundaryConditionLocalAssembler.h
ParameterLib::SpatialPosition position;
position.setElementID(Base::_element.getID());

double integral_measure = 1.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it if the following suggestion (fro lines 82-84) is taken .

@endJunction
Copy link
Member

@TomFischer Something is consistently wrong with the parallel tests:

[2019-11-14T13:22:03.107Z] 	  2 - ogs-Parallel_2D_StaggeredScheme_ComponentTransport_TracerSimulation-mpirun (Timeout)
[2019-11-14T13:22:03.107Z] 	  3 - ogs-Parallel_2D_StaggeredScheme_ComponentTransport_TracerSimulation-mpirun-vtkdiff (Failed)
[2019-11-14T13:22:03.107Z] 	  8 - ogs-ParallelFEM_GroundWaterFlow3D_NeumannBC-mpirun (Timeout)
[2019-11-14T13:22:03.107Z] 	  9 - ogs-ParallelFEM_GroundWaterFlow3D_NeumannBC-mpirun-vtkdiff (Failed)

I restarted the parallel jenkins job yesterday with same result...

@endJunction
Copy link
Member

I'd think that the integral_measure should not be 1 in an axisymmetric setup. A test would be nice... Let's discuss it on Monday.

@TomFischer TomFischer force-pushed the RiverRobin branch 4 times, most recently from f517b47 to 96979f7 Compare December 2, 2019 17:32
@TomFischer TomFischer merged commit 7e57984 into ufz:master Dec 3, 2019
@TomFischer TomFischer deleted the RiverRobin branch December 3, 2019 06:42
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenqing wenqing wenqing approved these changes

@renchao-lu renchao-lu renchao-lu approved these changes

@endJunction endJunction endJunction approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomFischer @endJunction @ogsbot @wenqing @renchao-lu