Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorter doc comments for fully-deprecated (ignored) fields/methods #397

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

extemporalgenome
Copy link
Contributor

@extemporalgenome extemporalgenome commented Jul 4, 2023

Fully ignored fields and methods can have shorter documentation, since knowledge of what they did does not help users of the current library version. Longer comments can also mislead some readers into believing these fields/methods are still useful to consider: for example, reading the first few sentences and thinking "this is exactly what I need," without reading far enough to see the Deprecated note at the bottom.

Deprecated-yet-usable fields/methods were not changed.

@ugorji ugorji merged commit 126da48 into ugorji:master Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants