CBOR: Reject malformed and invalid indefinite-length strings #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the CBOR spec, each chunk of an indefinite-length text string must be valid, or the entire indefinite-length string is invalid.
An indefinite-length text or byte string is not well-formed unless all of its chunks are of the same major type as the indefinite-length string.
This addresses two conformance issues: 1. All chunks of an indefinite-length text string must be valid, so if UTF-8 validation is enabled for text strings in DecodeOptions, it should be applied to each chunk. 2. All of the chunks of an indefinite-length text or byte string must have the same major type as the indefinite-length string itself. Indefinitely-length text strings can't contain byte strings and vice versa.
ugorji
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and potential fix for #403 and #404.
Makes decode return a error if a byte string is nested within an indefinite-length text string, or a text string is nested within an indefinite-length byte string. Separately, if the decode option ValidateUnicode is enabled, it will also apply to text strings that are nested within an indefinite-length text string.