Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executable file for linux added to /dist/base called base #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aish-where-ya
Copy link
Contributor

No description provided.

@aish-where-ya
Copy link
Contributor Author

This executable is for 64bit Linux OS

@techytushar
Copy link
Contributor

Nice work! Instead of adding all these files you can use the --onefile option of pyinstaller to just generate a single file, that would be easier and less bulky.

@aish-where-ya
Copy link
Contributor Author

It increases the size of executable file from 3.12 MB to 148.5MB. This makes it difficult to push and it needs a large file tracker (git lfs). What do you prefer?

@techytushar
Copy link
Contributor

I would suggest to keep one file, since when I tried to run the base file it was giving package errors, but when I compiled all into one file it ran fine. Tagging other mentors for suggestions: @omi10859 @lalitmee

@lalitmee
Copy link

Actually, it would be better if we use a single file. 👍

@aish-where-ya
Copy link
Contributor Author

The executable files are greater than 100MB so they need to be tracked using git lfs. According to Github's guidelines, this repo needs to have atleast 1 lfs object which has been already pushed by the owner so that other contributors can add large files using public forks. Due to security issues, public forks cannot add large files unless there already exist some in the repo. Please suggest a workaround to this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants