Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade TypeScript to 5.7 #54

Merged
merged 3 commits into from
Dec 1, 2024
Merged

feat: upgrade TypeScript to 5.7 #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4632297
feat: upgrade TS to 5.7
uhyo Nov 30, 2024
c59c060
feat: update type definition for TS 5.7
uhyo Dec 1, 2024
7e9a4a2
fix: tests
uhyo Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Follow below steps to run tests locally.
1. `npm run build:tsc`
2. `npm run build:lib`
3. `npm run build:package`
4. `npm run install` in tests directory
4. `npm install` in tests directory
5. `npm test` in tests directory

## Upgrading TypeScript version
Expand Down
2 changes: 1 addition & 1 deletion TypeScript
Open in desktop
Submodule TypeScript updated 3849 files
5 changes: 3 additions & 2 deletions build/logic/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ function isPartialReplacement(
betterFile: ts.SourceFile,
): boolean {
// Compare type parameters and herigate using full text.
if (interfaceDecl.name.escapedText === "Uint8Array") debugger;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

if (
interfaceDecl.typeParameters !== undefined &&
replacementDecl.typeParameters !== undefined &&
Expand All @@ -313,8 +314,8 @@ function isPartialReplacement(
if (
interfaceDecl.typeParameters.some((typeParam, index) => {
return (
typeParam.getFullText(originalFile) !==
rtp[index].getFullText(betterFile)
typeParam.getFullText(originalFile).trim() !==
rtp[index].getFullText(betterFile).trim()
);
})
) {
Expand Down
28 changes: 14 additions & 14 deletions docs/diff/dom.generated.d.ts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Index: dom.generated.d.ts
===================================================================
--- dom.generated.d.ts
+++ dom.generated.d.ts
@@ -2972,11 +2972,16 @@
@@ -3293,11 +3293,16 @@
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AudioParamMap) */
Expand All @@ -25,8 +25,8 @@ Index: dom.generated.d.ts
}

declare var AudioParamMap: {
@@ -3401,9 +3406,9 @@
blob(): Promise<Blob>;
@@ -3726,9 +3731,9 @@
bytes(): Promise<Uint8Array>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Request/formData) */
formData(): Promise<FormData>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Request/json) */
Expand All @@ -36,7 +36,7 @@ Index: dom.generated.d.ts
text(): Promise<string>;
}

@@ -6551,11 +6556,11 @@
@@ -6927,11 +6932,11 @@
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CustomStateSet) */
Expand All @@ -51,7 +51,7 @@ Index: dom.generated.d.ts
}

declare var CustomStateSet: {
@@ -8926,11 +8931,11 @@
@@ -9378,11 +9383,11 @@
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/EventCounts) */
Expand All @@ -66,7 +66,7 @@ Index: dom.generated.d.ts
}

declare var EventCounts: {
@@ -9462,11 +9467,16 @@
@@ -9914,11 +9919,16 @@
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/FontFaceSet/check) */
check(font: string, text?: string): boolean;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/FontFaceSet/load) */
Expand All @@ -86,7 +86,7 @@ Index: dom.generated.d.ts
addEventListener<K extends keyof FontFaceSetEventMap>(
type: K,
listener: (this: FontFaceSet, ev: FontFaceSetEventMap[K]) => any,
@@ -15358,15 +15368,16 @@
@@ -16210,15 +16220,16 @@
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Highlight/priority) */
priority: number;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Highlight/type) */
Expand All @@ -106,7 +106,7 @@ Index: dom.generated.d.ts
}

declare var Highlight: {
@@ -15375,15 +15386,16 @@
@@ -16227,15 +16238,16 @@
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HighlightRegistry) */
Expand All @@ -126,7 +126,7 @@ Index: dom.generated.d.ts
}

declare var HighlightRegistry: {
@@ -16809,11 +16821,16 @@
@@ -17663,11 +17675,16 @@
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/MIDIInputMap)
*/
Expand All @@ -146,7 +146,7 @@ Index: dom.generated.d.ts
}

declare var MIDIInputMap: {
@@ -16876,11 +16893,16 @@
@@ -17730,11 +17747,16 @@
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/MIDIOutputMap)
*/
Expand All @@ -166,7 +166,7 @@ Index: dom.generated.d.ts
}

declare var MIDIOutputMap: {
@@ -18739,9 +18761,9 @@
@@ -19528,9 +19550,9 @@
new (): NodeList;
};

Expand All @@ -177,7 +177,7 @@ Index: dom.generated.d.ts
* Performs the specified action for each node in an list.
* @param callbackfn A function that accepts up to three arguments. forEach calls the callbackfn function one time for each element in the list.
* @param thisArg An object to which the this keyword can refer in the callbackfn function. If thisArg is omitted, undefined is used as the this value.
@@ -21159,11 +21181,11 @@
@@ -22073,11 +22095,11 @@
};

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCStatsReport) */
Expand All @@ -192,7 +192,7 @@ Index: dom.generated.d.ts
}

declare var RTCStatsReport: {
@@ -33973,13 +33995,16 @@
@@ -34926,13 +34948,16 @@
handler: TimerHandler,
timeout?: number,
...arguments: any[]
Expand All @@ -211,7 +211,7 @@ Index: dom.generated.d.ts
declare var sessionStorage: Storage;
declare function addEventListener<K extends keyof WindowEventMap>(
type: K,
@@ -34638,4 +34663,125 @@
@@ -35607,4 +35632,125 @@
| "blob"
| "document"
| "json"
Expand Down
Loading