106 change status schema #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
powersaudrey25
force-pushed
the
106-change-status-schema
branch
from
c8bebb5 to
656ffaf
Compare
…Complete', 'Pending' in the event.py model for backend
…mething other than new valid kinds and changed them to valid kinds
…ent to valid kinds
ENH: Created migration for update to events table kind column FIX: Added commands to new migration, will re run the migration FIX: Modified jobs page on frontend to filter for new kinds FIX: Changed kind enums in frontend schema FIX: Found remaining places where still using old kinds, changed to new kinds BUG: migration did not work, redid it FIX: adjust to use new schema FIX: adjust frontend so app can build FIX: add not null constraint BUG: adding in rest of enum types FIX: Updated datetime test to use a different function BUG: Fix Migration Errors
Ivan-E-Johnson
force-pushed
the
106-change-status-schema
branch
from
dd9b87f to
c287d91
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We need to adjust our event_kind enum to have a 'Pending' and 'In Progress' role to adhere to our vision for displaying step-by-step job pipelines.
Implementation
A migration was created to implement this change.
Testing
To test these changes run APP_ENV=development alembic downgrade base and then APP_ENV=development alembic upgrade head.
If you are having trouble running migrations you will need to drop all tables and enums (message @powersaudrey25 or @zmorris248 if you have questions).
Run the orthanc logging script to create a job to verify the app is working.
Problems Faced
We originally had a migration that altered the 'kind' enum column in our 'events 'table. The migration ran successfully but our db was not actually changed. After researching we discovered you need to drop the enum column and recreate it for a change to take effect.
Notes