Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

118 orthanc reciever agent to download stable studies #131

Merged

Conversation

mbrzus
Copy link
Contributor

@mbrzus mbrzus commented Mar 5, 2024

Overview

This pull request introduces the fully functional system orchestrating the orthanc PACS servers with the example medical imaging product and connected to the TrackerAPI system.

This includes:

  1. our internal Orthanc PACS server
  2. "fake" hospital PACS server
  3. Orthanc Receiver Agent: an agent listening for new connections to our internal server. The agent manages the full data lifecycle within our system:
    • data receiving managment
    • data download to local system
    • data processing calling the example product
    • data upload to internal PACS
    • data return to the hospital
    • data deletion
  4. Othanc Logger: logs all study events to trackerAPI system

Testing

in your local environment:

  1. Start your virtual environments
  2. Start the PACS servers and upload example data
    bash example_tool/Orthanc/tmux_startup.sh
  3. Start the receiver agent
    python3 internal_servers/orthanc_reciever_agent.py
  4. Send data to modality in example hospital orthanc (manual click on the website)
  5. The agent will perform all the work automatically

Closes #24
Closes #34
Closes #35
Closes #61
Closes #68

@mbrzus mbrzus self-assigned this Mar 5, 2024
@mbrzus mbrzus linked an issue Mar 5, 2024 that may be closed by this pull request
@zmorris248
Copy link
Contributor

This looks really good! I think it needs to be rebased with main and made sure that the orthanc receiving and logging agents have the updated functionality and retested

@mbrzus mbrzus force-pushed the 118-orthanc-reciever-agent-to-download-stable-studies branch from 51b4fcb to 02fc0d4 Compare March 5, 2024 22:14
@mbrzus
Copy link
Contributor Author

mbrzus commented Mar 5, 2024

This looks really good! I think it needs to be rebased with main and made sure that the orthanc receiving and logging agents have the updated functionality and retested

I rebased with main.

Additionally, we might want to rename parts of the codebase from job to study. For example I still see the class from trackerAPI called JobConfigManager

Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@Ivan-E-Johnson Ivan-E-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@Ivan-E-Johnson Ivan-E-Johnson merged commit bd5207c into main Mar 6, 2024
7 checks passed
@Ivan-E-Johnson Ivan-E-Johnson deleted the 118-orthanc-reciever-agent-to-download-stable-studies branch March 6, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants