Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 make hospital table #133

Merged
merged 7 commits into from
Mar 6, 2024
Merged

115 make hospital table #133

merged 7 commits into from
Mar 6, 2024

Conversation

zmorris248
Copy link
Contributor

@zmorris248 zmorris248 commented Mar 6, 2024

Overview

This pull request creates the basic structure for a hospital object in the database. We will need to track hospitals as part of our enterprise system and as such require that to be part of our db schema

Implementation

  • Migration that creates the hospital table with attributes: id, hospital_name
  • Hospital model file
  • Hospital pydantic schema
  • Hospital services file that includes functions to create a hospital in the db

Testing

  • backend test for testing the hospitals model was added

Problems Faced

Notes

This is basic preliminary work, more work will be required for hospitals when we revise the user roles and create provider, product, and PACS.
Some things not included that will need to be included later:

  • Hospitals router that receives API requests
  • Router tests
  • Relationships between hospital and user, hospital and PACS
  • Functionality that allows for creation of hospitals on frontend
  • Seeding adjustments
  • Other integration work

Closes #115

@zmorris248 zmorris248 added this to the Sprint 3 Database Updates milestone Mar 6, 2024
@zmorris248 zmorris248 linked an issue Mar 6, 2024 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@Ivan-E-Johnson Ivan-E-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@Ivan-E-Johnson Ivan-E-Johnson merged commit d048312 into main Mar 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Hospital table
2 participants