Update for Angular 17 #476
Labels
Comments
|
Hey buddy,
Sure we would love a PR 💙.
Regards,
Santosh
…On Fri, 10 Nov 2023, 02:38 Brandon Largeau, ***@***.***> wrote:
Hello @santoshyadavdev <https://github.com/santoshyadavdev>,
Can we expect any update regarding support for Angular 17?
Do you accept any PR?
Have a good day!
—
Reply to this email directly, view it on GitHub
<#476>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC27EB6T4D3MTO7GKTRWZGDYDX7ZNAVCNFSM6AAAAAA7F7BC4CVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DOMZWGY4TSMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Awesome, I will (try to) work on it this week-end :) |
santoshyadavdev
pushed a commit
that referenced
this issue
Nov 26, 2023
Hello @santoshyadavdev, This PR fixes #476. What I did: - I couldn't use `yarn` at all this time, I switched to `npm` (even after everything was updated with `npm` and switching back to `yarn`) - I updated all packages to latest versions (except `jasmine-core`) - The nx cache is now located in the root folder of the repo, I added `.nx` in `.gitignore` - There was some problem with how the tsconfigs were done, I fixed all of them (it was causing problems with nx migrations) - I applied the migrations from nx - I migrated `ngu-carousel-example` to use the new control-flow - I did not update the `README.md` - I removed the cypress component testing config from `ngu-carousel-example` as it was more or less useless - I fixed errors found by the linter - I fixed unit tests - I removed `updateBuildableProjectDepsInPackageJson` from `ngu-carousel` as it was deprecated - removing it keeps the same behavior as if it was enable, that's what we want - I added missing `tsconfig.json` (cypress) in the `.eslintrc.json` of `ngu-carousel` - I updated the current SSR setup - I first tried to migrate the new `application` builder, but it was not working properly with modules. ~~I will investigate later if it comes from `nx` or the `Angular CLI`~~ (thanks @JeanMeche for his help) - Could be related to angular/angular#52998 - As said in https://riegler.fr/blog/2023-10-13-v17-builders: - `An interesting point to note is that if either 'ssr' or 'prerender' are set to 'true' in the configuration file, the pages served with 'ng serve' will be generated server side.` - This was not working, that's one of the reason I kept the same setup with `ssr-dev-server` & co. - I already did the migration to `browser-esbuild` when I migrated to `Angular 16`, so it is already using esbuild. - Another reason is that `ng serve` using the ssr is not using `server.ts` (which should not affect this repo, but let's play it safe), track angular/angular-cli#26323 - I cleaned `polyfills` usage - I updated the `CI` setup - Angular supports node starting version `18.13.0`, the CI now runs on `['18.13.0', '20']` - Updated to `actions/checkout@v4` & `actions/setup-node@v4` - Updated to use `npm` - I bumped `ngu-carousel` for `Angular 17` - I bumped `ngu-carousel` to `9.0.0` and I updated `README.md` TODO on your side: - Release a new major version `9.0.0` - Close branches related to package update Tell me if everything looks ok for you. Have a nice day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello @santoshyadavdev,
Can we expect any update regarding support for Angular 17?
Do you accept any PR?
Have a good day!
The text was updated successfully, but these errors were encountered: