Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve TrackByFn parameter issue #309

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Resolve TrackByFn parameter issue #309

merged 1 commit into from
Sep 30, 2020

Conversation

plamoni
Copy link
Contributor

@plamoni plamoni commented Sep 30, 2020

Fixes #295 by updating the call to trackBy to use the appropriate parameters per the documentation.

Fixes #295 by updating the call to trackBy to use the appropriate parameters per the [documentation](https://angular.io/api/core/IterableDifferFactory#create).
Copy link
Member

@santoshyadavdev santoshyadavdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot 😊

@santoshyadavdev santoshyadavdev merged commit 31f9221 into uiuniversal:master Sep 30, 2020
@plamoni plamoni deleted the fix-295 branch September 30, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nguCarouselDef trackBy item and index value
2 participants