Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ngu-carousel.ts #323

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Update ngu-carousel.ts #323

merged 1 commit into from
Jan 26, 2021

Conversation

plamoni
Copy link
Contributor

@plamoni plamoni commented Jan 23, 2021

Fixes #322

Declared types are not minified and therefore adding declare-ed interfaces prevents undesirable conflicts between dot- and string-references to properties.

Fixes #322 

Declared types [are not minified](https://developers.google.com/closure/compiler/docs/api-tutorial3#extocomp) and therefore adding `declare`-ed interfaces prevents undesirable conflicts between dot- and string-references to properties.
Copy link
Member

@santoshyadavdev santoshyadavdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santoshyadavdev santoshyadavdev merged commit d77197d into uiuniversal:master Jan 26, 2021
@plamoni plamoni deleted the patch-1 branch January 26, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed string and dot references to properties causes problems with minification
2 participants