Remove assignment to innerHTML #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the assignment of `''` to `innerHTML` with an assignment of `''` to `textContent` in order to resolve the CSP issue described in uiuniversal#339. The goal of this line of code is just to remove the content of the `style` node that is referenced by the `carouselCssNode` property. So there's no real difference between using `textContent` and `innerHTML`. Both have the same effect. However, since `innerHTML` potentially allows unsafe DOM injections, it should be avoided (such as in cases like this) when it's not needed. Resolves uiuniversal#339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the assignment of
''toinnerHTMLwith an assignment of''totextContentin order to resolve the CSP issue described in #339.The goal of this line of code is just to remove the content of the
stylenode that is referenced by thecarouselCssNodeproperty. So there's no real difference between usingtextContentandinnerHTML. Both have the same effect. However, sinceinnerHTMLpotentially allows unsafe DOM injections, it should be avoided (such as in cases like this) when it's not needed.Resolves #339