-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧲 Update vscalc()
function and add to documentation
#3520
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3520 +/- ##
==========================================
+ Coverage 31.20% 31.26% +0.05%
==========================================
Files 81 81
Lines 19440 19445 +5
==========================================
+ Hits 6066 6079 +13
+ Misses 13374 13366 -8 ☔ View full report in Codecov by Sentry. |
aa1f2c8
to
12d8b00
Compare
… and return values
… update related documentation and tests
…ion and update related tests
…elated documentation
… update related tests and documentation
…e related data files and documentation
…te related data files and documentation
…iable names more verbose
0e2978d
to
bad7f47
Compare
…d code references
…elated calculations and documentation
…elated calculations and documentation
…elated calculations and documentation
…culations and documentation
…te related calculations and documentation
…e related calculations and tests
…r plasma ohmic heating
… variables and update related references
…ariables and update related references
…and update related references
1c7f5cb
to
0deb114
Compare
0deb114
to
fe4d28e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor spelling correction but otherwise happy with the docs.
Description
The
vscalc()
function has now been improved and added to the documentation.web_
orvs_
can be used depending what better suites the contexth_
toind_
constants.f90
plasma_ohmic_heating()
, this also includes a boundary fix for the neo-classical enhancement for the resistivity that is only true forOld output:
New output:
Namespace changes
Functions
vscalc()
->calculate_volt_second_requirements()
Variables
gamma
->ejima_coeff
: Very generic name that provided no insightphiint
->vs_plasma_internal
: This has now been added to output.vsbrn
->vs_plasma_burn_required
vsstt
->vs_plasma_total_required
lpulse
->i_pulsed_plant
: Changed prefix to newi_
stylevsres
->vs_plasma_res_ramp
: Didnt specify the flux in what system and when the consumption occuredvsind
->vs_plasma_ind_ramp
: Didnt specify the flux in what system and when the consumption occuredvburn
->v_plasma_loop_burn
: Didnt specify system or where the voltage was measured.rlp
->ind_plasma
: Very generic name that provided no insightrli
->ind_plasma_internal_norm
: Very generic name that provided no insightrpfac
->f_plasma_res_neo
✨ New additions
v_plasma_loop_burn
: Wascalculated directly in the output section. Is now a tracked variable inphysics_variables.f90
. Value is returned incalculate_volt_second_requirements()
and has been added totest_calculate_volt_second_requirements()
Checklist
I confirm that I have completed the following checks: