Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📈 Make current vs time plot for plot_proc #3532

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Feb 7, 2025

This pull request includes several changes to the process/io/plot_proc.py file, primarily focusing on adding a new plotting function and making adjustments to existing plotting functions for clarity and consistency.

New Functionality:

  • Added plot_current_profiles_over_time function to plot the current profiles over time for PF circuits, CS coil, and plasma.

Adjustments to Existing Functions:

  • Updated the plot_nprofile function to modify axis labels and plot legends for better clarity.
  • Updated the plot_tprofile function to modify axis labels and plot legends for better clarity.

Integration of New Function:

  • Modified the main_plot function to include the new plot_current_profiles_over_time function, adding a new figure and subplot for this plot.

New plot at end of plot_proc output:

image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added the Documentation Improvements or additions to documentation label Feb 7, 2025
@chris-ashe chris-ashe self-assigned this Feb 7, 2025
@chris-ashe chris-ashe changed the title 📈 Make current vs time plot for plot proc 📈 Make current vs time plot for plot_proc Feb 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 2.17391% with 45 lines in your changes missing coverage. Please review.

Project coverage is 31.15%. Comparing base (6bac4f3) to head (085a754).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/io/plot_proc.py 2.17% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3532      +/-   ##
==========================================
- Coverage   31.21%   31.15%   -0.06%     
==========================================
  Files          81       81              
  Lines       19432    19472      +40     
==========================================
+ Hits         6065     6066       +1     
- Misses      13367    13406      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chris-ashe chris-ashe marked this pull request as ready for review February 7, 2025 14:18
Copy link
Collaborator

@j-a-foster j-a-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example plot looks like it could be tidied a bit but it looks good for now.

@chris-ashe chris-ashe force-pushed the make_current_vs_time_plot_for_plot_proc branch from 8950894 to adccc50 Compare February 10, 2025 10:02
Copy link
Contributor

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions, code looks good otherwise

process/io/plot_proc.py Show resolved Hide resolved
process/io/plot_proc.py Outdated Show resolved Hide resolved
process/io/plot_proc.py Outdated Show resolved Hide resolved
Copy link
Contributor

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with code

@chris-ashe chris-ashe force-pushed the make_current_vs_time_plot_for_plot_proc branch from 12c11a7 to 085a754 Compare February 12, 2025 13:17
@timothy-nunn timothy-nunn merged commit ec69fe6 into main Feb 12, 2025
18 checks passed
@timothy-nunn timothy-nunn deleted the make_current_vs_time_plot_for_plot_proc branch February 12, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants