-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 Fully update radiation docs, methods and variables #3541
Draft
chris-ashe
wants to merge
8
commits into
main
Choose a base branch
from
full_update_radiation_docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3541 +/- ##
==========================================
- Coverage 31.21% 29.87% -1.35%
==========================================
Files 81 81
Lines 19432 22463 +3031
==========================================
+ Hits 6065 6710 +645
- Misses 13367 15753 +2386 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow on from some work partially done in #3386
Namespace changes
Functions
Variables
pcoreradpv
->pden_plasma_core_rad_mw
pedgeradpv
->pden_plasma_outer_rad_mw
maxradwallload
->pflux_fw_rad_max
coreradius
->radius_plasma_core_norm
palpfwmw
->p_fw_alpha_mw
wallmw
->pflux_fw_neutron_mw
✨ New additions
p_plasma_sync_mw
: Represents the total synchrotron power from the plasma.🐛 Bugs
There was never a variable representing the total synchrotron power from the plasma, instead it was always outputted as
(pden_plasma_sync_mw*vol)
. This would cause parsing issues due to*
. A new variablep_plasma_sync_mw
has been created inphysics_variables.f90
to fix this.Checklist
I confirm that I have completed the following checks: