Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Fully update radiation docs, methods and variables #3541

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Feb 12, 2025

Description

Follow on from some work partially done in #3386

Namespace changes

Functions


Variables

  • pcoreradpv -> pden_plasma_core_rad_mw
  • pedgeradpv -> pden_plasma_outer_rad_mw
  • maxradwallload -> pflux_fw_rad_max
  • coreradius -> radius_plasma_core_norm
  • palpfwmw -> p_fw_alpha_mw
  • wallmw -> pflux_fw_neutron_mw

✨ New additions

  • p_plasma_sync_mw: Represents the total synchrotron power from the plasma.

🐛 Bugs

There was never a variable representing the total synchrotron power from the plasma, instead it was always outputted as (pden_plasma_sync_mw*vol). This would cause parsing issues due to *. A new variable p_plasma_sync_mw has been created in physics_variables.f90 to fix this.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added Physics Relating to the physics models Radiation Plasma radiated power labels Feb 12, 2025
@chris-ashe chris-ashe self-assigned this Feb 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 21.73913% with 36 lines in your changes missing coverage. Please review.

Project coverage is 29.87%. Comparing base (6bac4f3) to head (2f6f2f1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
process/physics.py 0.00% 11 Missing ⚠️
process/stellarator.py 0.00% 10 Missing ⚠️
process/io/sankey_funcs.py 0.00% 5 Missing ⚠️
process/ife.py 0.00% 3 Missing ⚠️
process/physics_functions.py 40.00% 3 Missing ⚠️
process/io/plot_proc.py 0.00% 2 Missing ⚠️
process/objectives.py 0.00% 1 Missing ⚠️
process/power.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3541      +/-   ##
==========================================
- Coverage   31.21%   29.87%   -1.35%     
==========================================
  Files          81       81              
  Lines       19432    22463    +3031     
==========================================
+ Hits         6065     6710     +645     
- Misses      13367    15753    +2386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Physics Relating to the physics models Radiation Plasma radiated power
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants