Optimisations #12
Merged
Optimisations #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
je-cook
force-pushed
the
optimisations
branch
from
8611a9f
to
3af2bcd
Compare
je-cook
commented
Nov 17, 2023
| @@ -307,18 +304,16 @@ def convergence_value( | |||
| The Lagrange multipliers for inequality constraints for the jth | |||
| evaluation point. | |||
| """ | |||
| ind_eq = min(lamda_equality.shape[0], result.eq.shape[0]) | |||
| ind_ieq = min(lamda_inequality.shape[0], result.ie.shape[0]) | |||
There was a problem hiding this comment.
This might be overkill but it will ensure the same functionality as zip
je-cook
force-pushed
the
optimisations
branch
from
3af2bcd
to
ef1b261
Compare
je-cook
commented
Nov 17, 2023
je-cook
force-pushed
the
optimisations
branch
from
0c45e52
to
ece9128
Compare
|
@je-cook is this ready for review? If not, can you request review when ready? |
|
@timothy-nunn I would but I obviously dont have permissions to do that |
|
@je-cook oh sorry. I assumed everyone in the UKAEA org would be allowed to request review (as is the case on PROCESS?). I'll do that for you tomorrow |
|
Im not in the org so that would be why, I think on PROCESS I might be an external collaborator |
timothy-nunn
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few optimisations to use numpy loops instead of python loops and some typing