Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move trelis script automatically #649

Merged
merged 4 commits into from
Jan 6, 2021

Conversation

shimwell
Copy link
Collaborator

Proposed changes

Currently when running neutronics simulations users have to copy over the make_faceteted_gemetry.py script from the examples into the local folder. This PR performs this copy operation automatically. This reduces the burden on the user but unfortunately it introduces a script file that is difficult to test into the pacakge. It is difficult to test as we have no method of getting trelis into the dockerfile. The trelis script was previously in the examples folder but is now in the pacakge so the code coverage should drop a little bit. Is this acceptable?

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell changed the base branch from develop to develop_combine January 6, 2021 11:47
@shimwell shimwell merged commit 472b31a into develop_combine Jan 6, 2021
@shimwell shimwell deleted the move_trelis_script_automatically branch February 10, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant