Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reflectivity option #670

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Conversation

shimwell
Copy link
Collaborator

@shimwell shimwell commented Jan 9, 2021

Proposed changes

When simulating sector models it is necessary to have reflecting surfaces. This addition facilitates reflecting surfaces being added to the neutronics description and the use of this key within the trelis script.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell
Copy link
Collaborator Author

Just failing on the sweep tasks

@shimwell shimwell merged commit 8d191b4 into develop_combine Jan 11, 2021
@shimwell shimwell deleted the adding_reflectivity_option branch January 11, 2021 11:37
@shimwell shimwell restored the adding_reflectivity_option branch January 11, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant