Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectra tally on cells #673

Merged
merged 7 commits into from
Jan 11, 2021
Merged

Spectra tally on cells #673

merged 7 commits into from
Jan 11, 2021

Conversation

shimwell
Copy link
Collaborator

Proposed changes

This adds the ability to tally neutron and photon spectra on the cells.

When defining a model we now have a few cell tallies that are supported (heating, flux, TBR, spectra).

The next tally to add is fast flux which is can be done in a very similar way to spectra but with a two group energy bin and then deletion of the values in the first (thermal) group. Admittedly this is probably not the most efficient way to implement such a tally but good to start somewhere.

Anyway the spectra is by default 709 CCFE energy group so perhaps this should also a user controllable an option in the future.

my_model = paramak.NeutronicsModel(
    geometry=self.my_shape,
    source=self.source,
    materials={'center_column_shield_mat': mat},
    cell_tallies=['heating', 'flux', 'TBR', 'spectra'],
    simulation_batches=2,
    simulation_particles_per_batch=2
)

Note the new keyword 'spectra'

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell changed the title Spectra tally Spectra tally on cells Jan 11, 2021
@shimwell
Copy link
Collaborator Author

This is just failing on the sweep tasks

@shimwell shimwell merged commit 2cfd300 into develop_combine Jan 11, 2021
@shimwell shimwell deleted the spectra_tally branch January 11, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant