Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert raises tests #681

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Conversation

billingsley-john
Copy link

Proposed changes

PR which re-organises unit tests so that assertions are correctly tested, and we don't get incorrect 'spillover' from previous tests.

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #681 (9299e01) into develop_combine (8d5d493) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           develop_combine     #681      +/-   ##
===================================================
+ Coverage            99.05%   99.07%   +0.02%     
===================================================
  Files                   68       68              
  Lines                 4222     4222              
===================================================
+ Hits                  4182     4183       +1     
+ Misses                  40       39       -1     
Impacted Files Coverage Δ
...ric_components/center_column_flat_top_hyperbola.py 100.00% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5d493...9299e01. Read the comment docs.

@billingsley-john billingsley-john merged commit c4d7037 into develop_combine Jan 15, 2021
@shimwell shimwell deleted the fix_assertRaises_tests branch February 10, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant