Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test matrix #760

Closed
wants to merge 7 commits into from
Closed

added test matrix #760

wants to merge 7 commits into from

Conversation

billingsley-john
Copy link

@billingsley-john billingsley-john commented Mar 4, 2021

Proposed changes

PR to add matrix testing to github actions CI for different cadquery versions

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@shimwell
Copy link
Collaborator

shimwell commented Mar 4, 2021

That was quick

Co-authored-by: Jonathan Shimwell <jonathan.shimwell@ukaea.uk>
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #760 (60947fe) into develop (cf27ff1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #760   +/-   ##
========================================
  Coverage    95.38%   95.38%           
========================================
  Files           72       72           
  Lines         4724     4724           
========================================
  Hits          4506     4506           
  Misses         218      218           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf27ff1...60947fe. Read the comment docs.

@shimwell
Copy link
Collaborator

shimwell commented Mar 4, 2021

Looks like the simulations using stl files made in cadquery version 2.1 work and the stl files made in cadquery master version doesn't work.

@billingsley-john
Copy link
Author

Looks like the simulations using stl files made in cadquery version 2.1 work and the stl files made in cadquery master version doesn't work.

I wonder at what point this stopped working. I suppose this managed to get through because the circle ci tests are pulling a static docker image - we are already seeing the benefits of this new testing approach.

@billingsley-john
Copy link
Author

Currently, when one set of tests in the matrix fails, it causes the cancellation of the other tests in the matrix. I.e. if tests fail for master, the tests running for 2.1 are cancelled. We don't want this - we want to return pass/fail for both scenarios each time.

@billingsley-john
Copy link
Author

Continued in #764

@billingsley-john billingsley-john deleted the add_matrix_testing branch March 12, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants