Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 support to NFLOG #1375

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add IPv6 support to NFLOG #1375

merged 2 commits into from
Mar 4, 2024

Conversation

NeroProtagonist
Copy link
Contributor

As in title, Nflog can now decode and print IPv6 + TCP/UDP/ICMPv6 packets.
Also updated all builds to use API 21 (latest available on NDK10).

Tested on Pixel 4a (arm architecture).
Compiled binaries for the other platforms but can't test them.

Added printing of IPv6 TCP/UDP/ICMPv6 packets with nflog.
@NeroProtagonist
Copy link
Contributor Author

Fixes #1232

Copy link
Owner

@ukanth ukanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ukanth ukanth merged commit 7a0b8cf into ukanth:beta Mar 4, 2024
1 check passed
@bsdice
Copy link

bsdice commented Apr 8, 2024

After xz backdooring, uploading binaries to a repo is seriously bad practice, imho.

Why is the x86 binary 4k bigger and the others only bytes?

@ukanth
Copy link
Owner

ukanth commented Apr 27, 2024

After xz backdooring, uploading binaries to a repo is seriously bad practice, imho.

Why is the x86 binary 4k bigger and the others only bytes?

I usually compile all the binaries from source and bundle it before releasing it to public.

@yashikada
Copy link

Why is the x86 binary 4k bigger and the others only bytes?

this happens because the arm architecture is more optimized than the x86 one, there are fewer instructions to do the same thing.
However you are absolutely right.

I usually compile all the binaries from source and bundle it

but this did not happen in this case. Are we sure that the author of this PR is reliable?
Wouldn't it be to have all the binaries compiled with github actions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants